find correct import path for _test packages #46
Conversation
tadeokondrak
force-pushed
the
correct-import-path-for-blackbox-tests
branch
from
9b1c5e4
to
844af9a
Compare
|
Was worried the CI failure ( What should I do here? I could add a blank import to make the problem go away, or set CI to list the packages it's testing, but neither of those seem good. |
|
Adding a blank import sounds fine to me. |
When using _test packages that used types from the corresponding
non-_test package before this commit, autogold would pass the wrong
package name to valast and the replacements would be in the form Type{}
instead of pkg.Type{}.
We now look for the package containing the tested file rather than
using the non-test package in the same directory.
tadeokondrak
force-pushed
the
correct-import-path-for-blackbox-tests
branch
from
844af9a
to
8eee69c
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 32.81% 33.41% +0.60%
==========================================
Files 6 7 +1
Lines 384 392 +8
==========================================
+ Hits 126 131 +5
- Misses 230 232 +2
- Partials 28 29 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
When using _test packages that used types from the corresponding
non-_test package before this commit, autogold would pass the wrong
package name to valast and the replacements would be in the form Type{}
instead of pkg.Type{}.
We now look for the package containing the tested file rather than
using the non-test package in the same directory.
When using _test packages that used types from the corresponding non-_test package before this commit, autogold would pass the wrong package name to valast and the replacements would be in the form Type{} instead of pkg.Type{}.
We now look for the package containing the tested file rather than using the non-test package in the same directory.
Fixes #25.
I included a test for
getPackageNameAndPath, but there's no test using actual files. Let me know if I should add one - it'd require two files and all the current tests only need one, so I haven't tried yet.I have tested this on my project and it does work.