introduce intermediate lib for GLFW compilation #31
Comments
slimsag
added a commit
to slimsag/mach-glfw
that referenced
this issue
Oct 24, 2021
Previously, @Avokadoen and @mattnite ran into issues including the GLFW library in other projects, e.g. Avokadoen/zig_vulkan#17 In #24 we removed the intermediate static library, which solved the issue. The problem is that when the function is invoked in the directory of the project including GLFW, then our code: ``` const lib = b.addStaticLibrary("glfw", "src/main.zig"); ``` Would refer to the project's `src/main.zig` -- not the GLFW library `main.zig`. Although removing the intermediate lib worked around the issue, it created a new one - slower compilation: hexops/mach#31 This fixes the issue by ensuring that the path we pass to `addStaticLibrary` is in fact absolute, not relative. Fixes hexops/mach#31 Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
ghost
mentioned this issue
slimsag
added a commit
to slimsag/mach-glfw
that referenced
this issue
Aug 26, 2022
Previously, @Avokadoen and @mattnite ran into issues including the GLFW library in other projects, e.g. Avokadoen/zig_vulkan#17 In #24 we removed the intermediate static library, which solved the issue. The problem is that when the function is invoked in the directory of the project including GLFW, then our code: ``` const lib = b.addStaticLibrary("glfw", "src/main.zig"); ``` Would refer to the project's `src/main.zig` -- not the GLFW library `main.zig`. Although removing the intermediate lib worked around the issue, it created a new one - slower compilation: hexops/mach#31 This fixes the issue by ensuring that the path we pass to `addStaticLibrary` is in fact absolute, not relative. Fixes hexops/mach#31 Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
glfw.linkcurrently from a project adds C sources to the compilation step, rather than linking an intermediate library, and so if you're using it from you're own project with C/C++ code compilation can be slower.We should default to emitting a static lib, and making
glfw.linklink to that.The text was updated successfully, but these errors were encountered: