glfw: fix key.press being set to release

[Avokadoen]

• By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

A very minor fix to correct key.press being set to GLFW_RELEASE instead of GLFW_PRESS

[Avokadoen]

Also if it is desired, I could look into replacing the int values defined in key and action into enum(c_int) and mod into a bitmask with packed struct. This would "ziggify" the API a bit, but might be undesirable if the change is too big of a deviation from raw glfw. The issue with key.press was detected because I am wrapping everything in the mentioned manner on my end. 👍

See: here for implementation

[slimsag]

Thanks for this @Avokadoen !

Do I understand correctly that the reason you prefer an enum(c_int) is because it's then a proper type, so you can pass it around as such in functions etc.? That makes sense to me, feel free to send that change!

The packed struct approach for mod also sounds good to me 👍

In general, I am not too worried about Zigifying / deviating a bit from the GLFW C API. I think that this is good, and prevents the need for "higher level" GLFW wrappers which is a good thing. Same reason I've opted for returning proper Zig errors instead of using a callback (although, GLFW error handling is a bit tricky, you really should ignore/log most errors.. so this may have been a bad call..) Of course, we should be mindful not to deviate too far as that would make updating to newer GLFW versions more tedious.

Thanks again!

[Avokadoen]

Cheers! I'll get on it after the weekend 👍