Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GLFW into sub-repository, use git subtree to sync #42

Merged
merged 2 commits into from
Oct 24, 2021
Merged

Conversation

slimsag
Copy link
Member

@slimsag slimsag commented Oct 24, 2021

I'm a big fan of monorepos for various reasons, but one huge drawback of them is the fact that one cannot easily:

  1. Discover sub-projects within a monorepo
  2. Answer the question e.g. "can I use GLFW from Mach? Or is it tied closely to that project for some reason?"
  3. Have light-weight dependencies: "I want to use GLFW from Mach, but I don't want to deal with everything else"

Things I like from monorepos include all the standard things:

  • It's easy to see development, issues, etc. all in one place
  • It's nice to be able to make cross-cutting changes all in one place.
  • It's nice to have "one version" for all code, tested together, etc.

This PR moves GLFW into a separate repository https://github.com/hexops/mach-glfw so others can depend on it, discover it, etc. Issues will be in this monorepo, but pull requests can be sent in that sub-repository or here in the monorepo.

git subtree push and git subtree pull are used to synchronize changes: pull requests to this repo are sync'd to that one, and vice-versa. For now this is a manual process I'll do, but can automate later.

Thanks @Avokadoen for pushing me to do this :) #39 (comment)

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
@slimsag slimsag added the glfw label Oct 24, 2021
@slimsag slimsag merged commit 02654a5 into main Oct 24, 2021
@slimsag slimsag deleted the sg/subtree branch October 24, 2021 14:19
@Avokadoen
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants