Skip to content

Commit

Permalink
Removing lingering GopherJS support debt (#267)
Browse files Browse the repository at this point in the history
* rename files to more clearly denote just JS requirement
* cleanup build tags (debt from legacy GopherJS support) - fixes an issue reported by rsc / Russ Cox in #261
* denote Go 1.14+ requirement with type-checking (possible now due to removing GopherJS support) - fixes #266
  • Loading branch information
slimsag authored Aug 16, 2020
1 parent 3dfb52c commit a2df9d3
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion dom_wasmjs_gopherjs.go → dom_js.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build go1.12,wasm,js js
// +build js

package vecty

Expand Down
2 changes: 1 addition & 1 deletion dom_native.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build go1.12,!wasm,!js
// +build !js

package vecty

Expand Down
13 changes: 0 additions & 13 deletions require_go_1_12.go

This file was deleted.

13 changes: 13 additions & 0 deletions require_go_1_14.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// +build !go1.14

package vecty

// Typechecking will pass except one error:
//
// # github.com/gopherjs/vecty
// ../../require_go_1_14.go:7:2: undefined: VECTY_REQUIRES_GO_1_14_PLUS
//

func init() {
VECTY_REQUIRES_GO_1_14_PLUS = "Vecty requires Go 1.14+"
}
2 changes: 1 addition & 1 deletion testsuite_wasmjs_test.go → testsuite_js_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build go1.12,wasm,js js
// +build js

package vecty

Expand Down
2 changes: 1 addition & 1 deletion testsuite_native_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build go1.12,!wasm,!js
// +build !js

package vecty

Expand Down

0 comments on commit a2df9d3

Please sign in to comment.