Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support biomejs as a formatter and linter #455

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #454

NOTE: I implemented this in such a way that it should be easier to add support for more formatters or linters in the future.

Copy link

codesandbox bot commented Apr 20, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: 29034d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 2:02am

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 79.90%. Comparing base (9d9de65) to head (29034d4).

Files Patch % Lines
packages/openapi-ts/src/index.ts 71.42% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   79.80%   79.90%   +0.10%     
==========================================
  Files          75       75              
  Lines        5986     6027      +41     
  Branches      608      608              
==========================================
+ Hits         4777     4816      +39     
- Misses       1208     1210       +2     
  Partials        1        1              
Flag Coverage Δ
unittests 79.90% <71.42%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, would only like to standardise defaults and docs a bit

docs/openapi-ts/configuration.md Outdated Show resolved Hide resolved
docs/openapi-ts/configuration.md Show resolved Hide resolved
docs/openapi-ts/configuration.md Outdated Show resolved Hide resolved
docs/openapi-ts/configuration.md Show resolved Hide resolved
docs/openapi-ts/migrating.md Outdated Show resolved Hide resolved
docs/openapi-ts/migrating.md Outdated Show resolved Hide resolved
@jordanshatford jordanshatford merged commit 2faa567 into main Apr 21, 2024
15 of 16 checks passed
@jordanshatford jordanshatford deleted the feat/support-biome-as-linter-and-formatter branch April 21, 2024 02:11
@github-actions github-actions bot mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Biome instead of ESLint/Prettier
2 participants