Investigate removing [PrimaryGlobal] and requiring [Exposed] #365

tobie · 2017-05-17T09:37:21Z

According to @annevk, it should be a relatively easy cleanup in the spec, but require lots of (easy) downstream changes.

[PrimaryGlobal] is a marker on the Window object that IDL fallbacks to when an interface is missing [Exposed].

Requiring [Exposed] on all interfaces would allow us to get rid of [PrimaryGlobal] and replace it with [Global].

tobie · 2017-05-17T09:41:52Z

See also: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26425

tobie · 2017-08-21T17:47:06Z

Seems from #420 that it would be worth flipping [SecureContext] over (e.g. to [AllowInNonSecureContext]) at the same time.

annevk · 2017-08-22T05:55:11Z

I think AllowInNonSecureContext would be nice, but I'm not sure about tightly coupling it with this. Is there agreement that we'd like to get rid of [PrimaryGlobal]? If so I'd be happy to start working on this at some point (adding annotations to various downstream specifications that is).

tobie · 2017-08-22T10:01:18Z

Note: removed a couple of confusing back and forth between @annevk and myself that were due to a misunderstanding on my part.

Needed to fix whatwg/webidl#365.

This can land after #2955. Needed to fix whatwg/webidl#365.

Needed for whatwg/webidl#365.

annevk · 2017-08-22T12:30:30Z

I created PRs for HTML and also for a thing I missed in DOM. DOM and other specifications I edit are already mostly accounted for since I've thought for a long time this is the way to go.

Also filed plinss/widlparser#27 to start with displaying warnings to those not using [Exposed].

…][mediaqueries] IDL: Use [Exposed] consistently This is necessary for whatwg/webidl#365.

tobie · 2017-08-22T15:53:45Z

Started working on a WebIDL PR for this. Should be able to push it later tonight or tomorrow.

This is necessary for whatwg/webidl#365.

Needed to fix whatwg/webidl#365.

Apparently this is needed for whatwg/webidl#365.

Apparently this is needed for whatwg/webidl#365. Generated from: commit cd6775e Author: Brian Birtles <birtles@gmail.com> Date: Wed Aug 23 14:13:31 2017 +0900 Use [Exposed] consistently Apparently this is needed for whatwg/webidl#365.

… to CSSAnimation and CSSTransition interfaces For whatwg/webidl#365.

Fixes whatwg#365. Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26425.

Needed to fix whatwg/webidl#365.

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/dom directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I63733c1a21476401370b2ec773c47f2a2c2ebe96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640701 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665455}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/css directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I667cab102b9b2cc7ea32ae60aa5de8545b56861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640301 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665462}

…mation Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/animation directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: Ied1032d67bcdaa52e7fa3265471fd53f4b5ddd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640743 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665476}

…pboard Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/animation directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I7f0616ef9ead191909aed5ae4b56940401cf7ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640745 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665783}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/events directory. [1] whatwg/webidl#365 The expected results of SecurityPolicyViolationEvent interface should be updated because the interface is exposed to Window and Worker. TESTS: http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt webexposed/global-interface-listing-dedicated-worker-expected.txt webexposed/global-interface-listing-shared-worker-expected.txt Bug: 963267 Change-Id: I34083358b19b16a069e84030d132aa82d939b859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641095 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#666168}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: Ic49520e48ebd24d139dd32b62c925cce306a2536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644890 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#666973}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/frame directory. [1] whatwg/webidl#365 The expected results of UserActivation interface should be updated because the interface is exposed to Window, Worker and AudioWorklet. TESTS: http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt webexposed/global-interface-listing-dedicated-worker-expected.txt webexposed/global-interface-listing-shared-worker-expected.txt Bug: 963267 Change-Id: I7398bc664890837017108d1310e7645584d8da23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641096 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#667534}

…l/forms Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html/forms directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I032c6e2954bc2e8011954f4a307a92325ac4156f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650686 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#667578}

…l/media Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html/media directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I1873b9b312f45953f1127d2f4577a07487b0038f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652751 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#667893}

…l/track Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html/track directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I480cbec30eb50355c89817622bcd196c4a813359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654751 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#668364}

…ize_observer Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/resize_observer directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I5358266254f921ff76999f4200b8617b13e0c1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654737 Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#668628}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/svg directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: Ib61ba7f4626d7bea694f23afa1684a126aa7fcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660385 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#669435}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. Although previous CLs have been adding the keywork in some submodules of html, there are still IDL files which don't have the keyword. So this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: Id48acfab328a7b63b4898fa397fa79527487a136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662090 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#669581}

…bluetooth Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/bluetooth directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I75c78dd466f0ab75d90550f4f43dc2630037514b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663834 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#670013}

…mediasession Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/mediasession directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: Ib291d4b8ceb8d390ff4cb1c7259fe271afa14ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666323 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#670408}

…mediastream Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/mediastream directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I842187ec2e3ea1f01568d249b9dea1d3bdbd9796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666764 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#670745}

…peerconnection Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/peerconnection directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I158b9007fb06ed86c12a784fd462101102bb69e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668588 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#670832}

…odules/native_file_system Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/native_file_system directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I18e44effcfc6b6e76825a2e28192111419cbd607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668568 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#670833}

…plugins Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/payments directory. Additionally, this CL updates the URLs of the specificiations. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I6fdaba4bac93e7538756ccb8b931261035c2ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670667 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#671502}

…sensor Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/sensor directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I7f5dc89c160d8e369b9ac2609aee506315263305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672075 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#671948}

…remoteplayback Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/remoteplayback directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I6cdacad1e184eb2b7cc126f04a3e252cd032e463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673405 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#672829}

…screen_orientation Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/screen_orientation directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: If6aeef6479a6d975a52e5135fa5956918f1c31ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672609 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#672832}

…webaudio Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/webaudio directory. [1] whatwg/webidl#365 Bug: 963267 Change-Id: I3b9fe29f2b7e6ca09f09eaabbf56bf4e489bf56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678097 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#674041}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the Document IDL file which doesn't have the keyword yet. [1] whatwg/webidl#365 Spec URL: https://dom.spec.whatwg.org/#interface-document Bug: 963267 Change-Id: Iea5ef8f926083eafe246761cdda86c8fd8942c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687875 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#674730}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the Document IDL file which doesn't have the keyword yet. [1] whatwg/webidl#365 Spec URL: https://dom.spec.whatwg.org/#interface-shadowroot Bug: 963267 Change-Id: I85293197a7257ae8e63ff70b267a3cd2057c0703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687711 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#674739}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in CustomElementRegistry interface. [1] whatwg/webidl#365 Bug: 963267 Change-Id: Iab87685196399cfd46c17610ed1f25c84c5ef1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682358 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#674742}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the Selection IDL file which doesn't have the keyword yet. [1] whatwg/webidl#365 Spec URL: https://w3c.github.io/selection-api/#selection-interface Bug: 963267 Change-Id: I683957aa1386c9539b1026a7bf28cd242886be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687570 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#674968}

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the HTMLTrackElement IDL file which doesn't have the keyword yet. [1] whatwg/webidl#365 Spec URL: https://html.spec.whatwg.org/C/#the-track-element Bug: 963267 Change-Id: Ia9c5c1fd20e4f0ac1053f808e1cea17e063700e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694581 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#675951}

annevk mentioned this issue May 22, 2017

Specify window.webkitURL as an alias to URL whatwg/url#312

Merged

tobie mentioned this issue Aug 21, 2017

Using [SecureContext] when it's implied? #420

Closed

whatwg deleted a comment from annevk Aug 22, 2017

annevk added a commit to whatwg/html that referenced this issue Aug 22, 2017

Use Exposed=Window consistently

1f61de8

Needed to fix whatwg/webidl#365.

annevk mentioned this issue Aug 22, 2017

Use Exposed=Window consistently whatwg/html#2955

Merged

annevk added a commit to whatwg/html that referenced this issue Aug 22, 2017

Remove [PrimaryGlobal]

8c69161

This can land after #2955. Needed to fix whatwg/webidl#365.

annevk mentioned this issue Aug 22, 2017

Remove [PrimaryGlobal] whatwg/html#2956

Merged

annevk added a commit to whatwg/dom that referenced this issue Aug 22, 2017

Add [Exposed] to DOMTokenList

eb38c12

Needed for whatwg/webidl#365.

This was referenced Aug 22, 2017

Add [Exposed] to DOMTokenList whatwg/dom#499

Merged

Warn for interfaces that lack [Exposed=...] plinss/widlparser#27

Open

zcorpan added a commit to w3c/csswg-drafts that referenced this issue Aug 22, 2017

[css-animations][css-conditional][css-font-loading][cssom-view][cssom…

63cc8d3

…][mediaqueries] IDL: Use [Exposed] consistently This is necessary for whatwg/webidl#365.

zcorpan mentioned this issue Aug 22, 2017

[css-animations][css-conditional][css-font-loading][cssom-view][cssom][mediaqueries] IDL: Use [Exposed] consistently w3c/csswg-drafts#1749

Merged

zcorpan added a commit to w3c/webvtt that referenced this issue Aug 22, 2017

Use [Exposed] consistently

30dab2c

This is necessary for whatwg/webidl#365.

zcorpan mentioned this issue Aug 22, 2017

Use [Exposed] consistently w3c/webvtt#358

Closed

annevk closed this as completed in whatwg/html#2955 Aug 22, 2017

annevk added a commit to whatwg/html that referenced this issue Aug 22, 2017

Use [Exposed=Window] consistently

c441d70

Needed to fix whatwg/webidl#365.

annevk reopened this Aug 22, 2017

birtles added a commit to w3c/web-animations that referenced this issue Aug 23, 2017

Use [Exposed] consistently

cd6775e

Apparently this is needed for whatwg/webidl#365.

birtles added a commit to w3c/csswg-drafts that referenced this issue Aug 23, 2017

[css-animations-2][css-transitions-2] Add [Exposed=Window] annotation…

f7768bd

… to CSSAnimation and CSSTransition interfaces For whatwg/webidl#365.

tobie added a commit to tobie/webidl that referenced this issue Aug 23, 2017

Make [Exposed] mandatory, remove [PrimaryGlobal]

c5b5d23

Fixes whatwg#365. Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26425.

tobie mentioned this issue Aug 23, 2017

Make [Exposed] mandatory, remove [PrimaryGlobal] #423

Merged

zcorpan added a commit to w3c/css-houdini-drafts that referenced this issue Aug 24, 2017

Use [Exposed] consistently (needs fixup, replace "???")

6d73d10

Needed to fix whatwg/webidl#365.

zcorpan mentioned this issue Aug 24, 2017

Use [Exposed] consistently (needs fixup, replace "???") w3c/css-houdini-drafts#464

Closed

saschanaz mentioned this issue Jun 6, 2019

[geometry] Add explicit [Exposed] to DOMRectList w3c/fxtf-drafts#341

Merged

RByers mentioned this issue Nov 23, 2022

Add discussion of unexposed interfaces? #1236

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Investigate removing [PrimaryGlobal] and requiring [Exposed] #365

Investigate removing [PrimaryGlobal] and requiring [Exposed] #365

tobie commented May 17, 2017 •

edited

Loading

tobie commented May 17, 2017

tobie commented Aug 21, 2017

annevk commented Aug 22, 2017

tobie commented Aug 22, 2017 •

edited

Loading

annevk commented Aug 22, 2017

tobie commented Aug 22, 2017

Investigate removing [PrimaryGlobal] and requiring [Exposed] #365

Investigate removing [PrimaryGlobal] and requiring [Exposed] #365

Comments

tobie commented May 17, 2017 • edited Loading

tobie commented May 17, 2017

tobie commented Aug 21, 2017

annevk commented Aug 22, 2017

tobie commented Aug 22, 2017 • edited Loading

annevk commented Aug 22, 2017

tobie commented Aug 22, 2017

tobie commented May 17, 2017 •

edited

Loading

tobie commented Aug 22, 2017 •

edited

Loading