New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing [PrimaryGlobal] and requiring [Exposed] #365

Closed
tobie opened this Issue May 17, 2017 · 18 comments

Comments

Projects
None yet
8 participants
@tobie
Collaborator

tobie commented May 17, 2017

According to @annevk, it should be a relatively easy cleanup in the spec, but require lots of (easy) downstream changes.

[PrimaryGlobal] is a marker on the Window object that IDL fallbacks to when an interface is missing [Exposed].

Requiring [Exposed] on all interfaces would allow us to get rid of [PrimaryGlobal] and replace it with [Global].

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie
Collaborator

tobie commented May 17, 2017

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie Aug 21, 2017

Collaborator

Seems from #420 that it would be worth flipping [SecureContext] over (e.g. to [AllowInNonSecureContext]) at the same time.

Collaborator

tobie commented Aug 21, 2017

Seems from #420 that it would be worth flipping [SecureContext] over (e.g. to [AllowInNonSecureContext]) at the same time.

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Aug 22, 2017

Collaborator

I think AllowInNonSecureContext would be nice, but I'm not sure about tightly coupling it with this. Is there agreement that we'd like to get rid of [PrimaryGlobal]? If so I'd be happy to start working on this at some point (adding annotations to various downstream specifications that is).

Collaborator

annevk commented Aug 22, 2017

I think AllowInNonSecureContext would be nice, but I'm not sure about tightly coupling it with this. Is there agreement that we'd like to get rid of [PrimaryGlobal]? If so I'd be happy to start working on this at some point (adding annotations to various downstream specifications that is).

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie Aug 22, 2017

Collaborator

Note: removed a couple of confusing back and forth between @annevk and myself that were due to a misunderstanding on my part.

Collaborator

tobie commented Aug 22, 2017

Note: removed a couple of confusing back and forth between @annevk and myself that were due to a misunderstanding on my part.

Repository owner deleted a comment from annevk Aug 22, 2017

annevk added a commit to whatwg/html that referenced this issue Aug 22, 2017

annevk added a commit to whatwg/html that referenced this issue Aug 22, 2017

Remove [PrimaryGlobal]
This can land after #2955. Needed to fix heycam/webidl#365.

annevk added a commit to whatwg/dom that referenced this issue Aug 22, 2017

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Aug 22, 2017

Collaborator

I created PRs for HTML and also for a thing I missed in DOM. DOM and other specifications I edit are already mostly accounted for since I've thought for a long time this is the way to go.

Also filed plinss/widlparser#27 to start with displaying warnings to those not using [Exposed].

Collaborator

annevk commented Aug 22, 2017

I created PRs for HTML and also for a thing I missed in DOM. DOM and other specifications I edit are already mostly accounted for since I've thought for a long time this is the way to go.

Also filed plinss/widlparser#27 to start with displaying warnings to those not using [Exposed].

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie Aug 22, 2017

Collaborator

Started working on a WebIDL PR for this. Should be able to push it later tonight or tomorrow.

Collaborator

tobie commented Aug 22, 2017

Started working on a WebIDL PR for this. Should be able to push it later tonight or tomorrow.

zcorpan added a commit to w3c/webvtt that referenced this issue Aug 22, 2017

annevk added a commit to whatwg/html that referenced this issue Aug 22, 2017

@annevk annevk reopened this Aug 22, 2017

birtles added a commit to w3c/web-animations that referenced this issue Aug 23, 2017

Use [Exposed] consistently
Apparently this is needed for heycam/webidl#365.

webanimbot pushed a commit to w3c/web-animations that referenced this issue Aug 23, 2017

Use [Exposed] consistently
Apparently this is needed for heycam/webidl#365.

Generated from:

commit cd6775e
Author: Brian Birtles <birtles@gmail.com>
Date:   Wed Aug 23 14:13:31 2017 +0900

    Use [Exposed] consistently

    Apparently this is needed for heycam/webidl#365.

birtles added a commit to w3c/csswg-drafts that referenced this issue Aug 23, 2017

zcorpan added a commit to w3c/css-houdini-drafts that referenced this issue Aug 24, 2017

@annevk annevk referenced this issue Aug 31, 2017

Closed

Use [Exposed] #1297

annevk added a commit to whatwg/dom that referenced this issue Aug 31, 2017

@dontcallmedom

This comment has been minimized.

Show comment
Hide comment
@dontcallmedom

dontcallmedom Sep 6, 2017

Contributor

in case this helps, I ran a custom report on the WebIDL crawl made by our Reffy tool, and found the following specs / interfaces that are neither Exposed nor NoInterfaceObject:

Specifications that defined WebIDL interfaces that are neither Exposed nor NoInterfaceObject

  • Accelerometer: Accelerometer, LinearAccelerationSensor, GravitySensor
  • Ambient Light Sensor: AmbientLightSensor
  • Battery Status API: BatteryManager
  • Clipboard API and events: ClipboardEvent, Clipboard
  • Content Security Policy Level 3: SecurityPolicyViolationEvent
  • Cooperative Scheduling of Background Tasks: IdleDeadline
  • CSS Object Model (CSSOM): MediaList, StyleSheet, CSSStyleSheet, StyleSheetList, CSSRuleList, CSSRule, CSSStyleRule, CSSImportRule, CSSGroupingRule, CSSPageRule, CSSMarginRule, CSSNamespaceRule, CSSStyleDeclaration, CSS
  • CSS Pseudo-Elements Module Level 4: CSSPseudoElement, CSSPseudoElementList
  • CSS Typed OM Level 1: CSSStyleValue, StylePropertyMapReadOnly, StylePropertyMap, CSSUnparsedValue, CSSVariableReferenceValue, CSSKeywordValue, CSSNumericValue, CSSUnitValue, CSSMathValue, CSSMathSum, CSSMathProduct, CSSMathNegate, CSSMathInvert, CSSMathMin, CSSMathMax, CSSNumericArray, CSSTransformValue, CSSTransformComponent, CSSTranslation, CSSRotation, CSSScale, CSSSkew, CSSPerspective, CSSMatrixComponent, CSSPositionValue, CSSResourceValue, CSSImageValue, CSSURLImageValue, CSSFontFaceValue
  • CSSOM View Module: MediaQueryList, MediaQueryListEvent, Screen, CaretPosition
  • DeviceOrientation Event Specification: DeviceOrientationEvent, DeviceMotionEvent
  • DOM Parsing and Serialization: DOMParser, XMLSerializer
  • DOM Standard: MutationObserver
  • Element Traversal Specification: ElementTraversal
  • Encrypted Media Extensions: MediaKeySystemAccess, MediaKeys, MediaKeySession, MediaKeyStatusMap, MediaKeyMessageEvent, MediaEncryptedEvent
  • Gamepad: Gamepad, GamepadButton, GamepadEvent
  • Generic Sensor API: Sensor, SensorErrorEvent
  • Gyroscope: Gyroscope
  • HTML Standard: RadioNodeList, HTMLUnknownElement, AudioTrack, VideoTrackList, VideoTrack, CanvasRenderingContext2D, Window
  • Magnetometer: Magnetometer, UncalibratedMagnetometer
  • Media Capture and Streams: InputDeviceInfo
  • Media Capture from DOM Elements: CanvasCaptureMediaStreamTrack
  • Media Source Extensions™: MediaSource, SourceBuffer, SourceBufferList
  • MediaStream Image Capture: ImageCapture, PhotoCapabilities, MediaSettingsRange
  • MediaStream Recording: MediaRecorder, BlobEvent
  • Navigation Timing Level 2: PerformanceNavigationTiming
  • Orientation Sensor: OrientationSensor, AbsoluteOrientationSensor, RelativeOrientationSensor
  • Payment Handler API: PaymentInstruments
  • Payment Request API: PaymentRequest, PaymentAddress, PaymentResponse, PaymentRequestUpdateEvent
  • Pointer Events - Level 2: PointerEvent
  • Presentation API: Presentation, PresentationRequest, PresentationAvailability, PresentationConnectionAvailableEvent, PresentationConnection, PresentationConnectionCloseEvent, PresentationReceiver, PresentationConnectionList
  • Proximity Sensor: ProximitySensor
  • Remote Playback API: RemotePlayback
  • Scalable Vector Graphics (SVG) 2: SVGElement, SVGGraphicsElement, SVGGeometryElement, SVGNumber, SVGLength, SVGAngle, SVGNameList, SVGNumberList, SVGLengthList, SVGAnimatedBoolean, SVGAnimatedEnumeration, SVGAnimatedInteger, SVGAnimatedNumber, SVGAnimatedLength, SVGAnimatedAngle, SVGAnimatedString, SVGAnimatedRect, SVGAnimatedNumberList, SVGAnimatedLengthList, SVGStringList, SVGUnitTypes, SVGSVGElement, SVGGElement, SVGUnknownElement, SVGDefsElement, SVGDescElement, SVGMetadataElement, SVGTitleElement, SVGSymbolElement, SVGUseElement, SVGUseElementShadowRoot, ShadowAnimation, SVGSwitchElement, SVGStyleElement, SVGTransform, SVGTransformList, SVGAnimatedTransformList, SVGPreserveAspectRatio, SVGAnimatedPreserveAspectRatio, SVGPathElement, SVGRectElement, SVGCircleElement, SVGEllipseElement, SVGLineElement, SVGMeshElement, SVGPointList, SVGPolylineElement, SVGPolygonElement, SVGTextContentElement, SVGTextPositioningElement, SVGTextElement, SVGTSpanElement, SVGTextPathElement, SVGImageElement, SVGForeignObjectElement, SVGMarkerElement, SVGSolidcolorElement, SVGGradientElement, SVGLinearGradientElement, SVGRadialGradientElement, SVGMeshGradientElement, SVGMeshrowElement, SVGMeshpatchElement, SVGStopElement, SVGPatternElement, SVGHatchElement, SVGHatchpathElement, SVGCursorElement, SVGScriptElement, SVGAElement, SVGViewElement
  • Selection API: Selection
  • Static Range: StaticRange
  • The Screen Orientation API: ScreenOrientation
  • Touch Events - Level 2: Touch, TouchList, TouchEvent
  • UI Events: UIEvent, FocusEvent, MouseEvent, WheelEvent, InputEvent, KeyboardEvent, CompositionEvent
  • Wake Lock API: WakeLock, WakeLockRequest
  • Web App Manifest: BeforeInstallPromptEvent
  • Web Authentication: An API for accessing Public Key Credentials - Level 1: PublicKeyCredential, AuthenticatorResponse, AuthenticatorAttestationResponse, AuthenticatorAssertionResponse
  • WebGL 2.0 Specification: WebGLQuery, WebGLSampler, WebGLSync, WebGLTransformFeedback, WebGLVertexArrayObject, WebGL2RenderingContext
  • WebGL Specification: WebGLObject, WebGLBuffer, WebGLFramebuffer, WebGLProgram, WebGLRenderbuffer, WebGLShader, WebGLTexture, WebGLUniformLocation, WebGLActiveInfo, WebGLShaderPrecisionFormat, WebGLRenderingContext, WebGLContextEvent
  • WebRTC 1.0: Real-time Communication Between Browsers: RTCPeerConnection, RTCSessionDescription, RTCIceCandidate, RTCPeerConnectionIceEvent, RTCPeerConnectionIceErrorEvent, RTCCertificate, RTCRtpSender, RTCRtpReceiver, RTCRtpContributingSource, RTCRtpSynchronizationSource, RTCRtpTransceiver, RTCDtlsTransport, RTCIceTransport, RTCTrackEvent, RTCSctpTransport, RTCDataChannel, RTCDataChannelEvent, RTCDTMFSender, RTCDTMFToneChangeEvent, RTCStatsReport, RTCIdentityAssertion
  • Worklets Level 1: Worklet

(checkboxes for specs where issue or PR has been filed)

Contributor

dontcallmedom commented Sep 6, 2017

in case this helps, I ran a custom report on the WebIDL crawl made by our Reffy tool, and found the following specs / interfaces that are neither Exposed nor NoInterfaceObject:

Specifications that defined WebIDL interfaces that are neither Exposed nor NoInterfaceObject

  • Accelerometer: Accelerometer, LinearAccelerationSensor, GravitySensor
  • Ambient Light Sensor: AmbientLightSensor
  • Battery Status API: BatteryManager
  • Clipboard API and events: ClipboardEvent, Clipboard
  • Content Security Policy Level 3: SecurityPolicyViolationEvent
  • Cooperative Scheduling of Background Tasks: IdleDeadline
  • CSS Object Model (CSSOM): MediaList, StyleSheet, CSSStyleSheet, StyleSheetList, CSSRuleList, CSSRule, CSSStyleRule, CSSImportRule, CSSGroupingRule, CSSPageRule, CSSMarginRule, CSSNamespaceRule, CSSStyleDeclaration, CSS
  • CSS Pseudo-Elements Module Level 4: CSSPseudoElement, CSSPseudoElementList
  • CSS Typed OM Level 1: CSSStyleValue, StylePropertyMapReadOnly, StylePropertyMap, CSSUnparsedValue, CSSVariableReferenceValue, CSSKeywordValue, CSSNumericValue, CSSUnitValue, CSSMathValue, CSSMathSum, CSSMathProduct, CSSMathNegate, CSSMathInvert, CSSMathMin, CSSMathMax, CSSNumericArray, CSSTransformValue, CSSTransformComponent, CSSTranslation, CSSRotation, CSSScale, CSSSkew, CSSPerspective, CSSMatrixComponent, CSSPositionValue, CSSResourceValue, CSSImageValue, CSSURLImageValue, CSSFontFaceValue
  • CSSOM View Module: MediaQueryList, MediaQueryListEvent, Screen, CaretPosition
  • DeviceOrientation Event Specification: DeviceOrientationEvent, DeviceMotionEvent
  • DOM Parsing and Serialization: DOMParser, XMLSerializer
  • DOM Standard: MutationObserver
  • Element Traversal Specification: ElementTraversal
  • Encrypted Media Extensions: MediaKeySystemAccess, MediaKeys, MediaKeySession, MediaKeyStatusMap, MediaKeyMessageEvent, MediaEncryptedEvent
  • Gamepad: Gamepad, GamepadButton, GamepadEvent
  • Generic Sensor API: Sensor, SensorErrorEvent
  • Gyroscope: Gyroscope
  • HTML Standard: RadioNodeList, HTMLUnknownElement, AudioTrack, VideoTrackList, VideoTrack, CanvasRenderingContext2D, Window
  • Magnetometer: Magnetometer, UncalibratedMagnetometer
  • Media Capture and Streams: InputDeviceInfo
  • Media Capture from DOM Elements: CanvasCaptureMediaStreamTrack
  • Media Source Extensions™: MediaSource, SourceBuffer, SourceBufferList
  • MediaStream Image Capture: ImageCapture, PhotoCapabilities, MediaSettingsRange
  • MediaStream Recording: MediaRecorder, BlobEvent
  • Navigation Timing Level 2: PerformanceNavigationTiming
  • Orientation Sensor: OrientationSensor, AbsoluteOrientationSensor, RelativeOrientationSensor
  • Payment Handler API: PaymentInstruments
  • Payment Request API: PaymentRequest, PaymentAddress, PaymentResponse, PaymentRequestUpdateEvent
  • Pointer Events - Level 2: PointerEvent
  • Presentation API: Presentation, PresentationRequest, PresentationAvailability, PresentationConnectionAvailableEvent, PresentationConnection, PresentationConnectionCloseEvent, PresentationReceiver, PresentationConnectionList
  • Proximity Sensor: ProximitySensor
  • Remote Playback API: RemotePlayback
  • Scalable Vector Graphics (SVG) 2: SVGElement, SVGGraphicsElement, SVGGeometryElement, SVGNumber, SVGLength, SVGAngle, SVGNameList, SVGNumberList, SVGLengthList, SVGAnimatedBoolean, SVGAnimatedEnumeration, SVGAnimatedInteger, SVGAnimatedNumber, SVGAnimatedLength, SVGAnimatedAngle, SVGAnimatedString, SVGAnimatedRect, SVGAnimatedNumberList, SVGAnimatedLengthList, SVGStringList, SVGUnitTypes, SVGSVGElement, SVGGElement, SVGUnknownElement, SVGDefsElement, SVGDescElement, SVGMetadataElement, SVGTitleElement, SVGSymbolElement, SVGUseElement, SVGUseElementShadowRoot, ShadowAnimation, SVGSwitchElement, SVGStyleElement, SVGTransform, SVGTransformList, SVGAnimatedTransformList, SVGPreserveAspectRatio, SVGAnimatedPreserveAspectRatio, SVGPathElement, SVGRectElement, SVGCircleElement, SVGEllipseElement, SVGLineElement, SVGMeshElement, SVGPointList, SVGPolylineElement, SVGPolygonElement, SVGTextContentElement, SVGTextPositioningElement, SVGTextElement, SVGTSpanElement, SVGTextPathElement, SVGImageElement, SVGForeignObjectElement, SVGMarkerElement, SVGSolidcolorElement, SVGGradientElement, SVGLinearGradientElement, SVGRadialGradientElement, SVGMeshGradientElement, SVGMeshrowElement, SVGMeshpatchElement, SVGStopElement, SVGPatternElement, SVGHatchElement, SVGHatchpathElement, SVGCursorElement, SVGScriptElement, SVGAElement, SVGViewElement
  • Selection API: Selection
  • Static Range: StaticRange
  • The Screen Orientation API: ScreenOrientation
  • Touch Events - Level 2: Touch, TouchList, TouchEvent
  • UI Events: UIEvent, FocusEvent, MouseEvent, WheelEvent, InputEvent, KeyboardEvent, CompositionEvent
  • Wake Lock API: WakeLock, WakeLockRequest
  • Web App Manifest: BeforeInstallPromptEvent
  • Web Authentication: An API for accessing Public Key Credentials - Level 1: PublicKeyCredential, AuthenticatorResponse, AuthenticatorAttestationResponse, AuthenticatorAssertionResponse
  • WebGL 2.0 Specification: WebGLQuery, WebGLSampler, WebGLSync, WebGLTransformFeedback, WebGLVertexArrayObject, WebGL2RenderingContext
  • WebGL Specification: WebGLObject, WebGLBuffer, WebGLFramebuffer, WebGLProgram, WebGLRenderbuffer, WebGLShader, WebGLTexture, WebGLUniformLocation, WebGLActiveInfo, WebGLShaderPrecisionFormat, WebGLRenderingContext, WebGLContextEvent
  • WebRTC 1.0: Real-time Communication Between Browsers: RTCPeerConnection, RTCSessionDescription, RTCIceCandidate, RTCPeerConnectionIceEvent, RTCPeerConnectionIceErrorEvent, RTCCertificate, RTCRtpSender, RTCRtpReceiver, RTCRtpContributingSource, RTCRtpSynchronizationSource, RTCRtpTransceiver, RTCDtlsTransport, RTCIceTransport, RTCTrackEvent, RTCSctpTransport, RTCDataChannel, RTCDataChannelEvent, RTCDTMFSender, RTCDTMFToneChangeEvent, RTCStatsReport, RTCIdentityAssertion
  • Worklets Level 1: Worklet

(checkboxes for specs where issue or PR has been filed)

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Sep 6, 2017

Collaborator

That's amazing, thanks!

Collaborator

annevk commented Sep 6, 2017

That's amazing, thanks!

dontcallmedom added a commit to w3c/webrtc-pc that referenced this issue Sep 6, 2017

Annotate all interfaces with Exposed extended attribute
WebIDL is moving to making it a required extended attribute heycam/webidl#365

annevk added a commit to whatwg/html that referenced this issue Sep 6, 2017

Use [Exposed=Window] even more
Missed a couple the last time around. Helps with heycam/webidl#365.

Remainder is tracked by #2956.
@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Sep 15, 2017

Collaborator

All boxes ticked.

Collaborator

annevk commented Sep 15, 2017

All boxes ticked.

@garykac

This comment has been minimized.

Show comment
Hide comment
@garykac

garykac Sep 15, 2017

For Constructors, I usually see is as:
[Constructor(...), Exposed=Window]

But sometimes (eg: in webvr) it is:
[Exposed=Window, Constructor(...)]

Do we want to be consistent with placing this annotation at the end, or does it not matter?

garykac commented Sep 15, 2017

For Constructors, I usually see is as:
[Constructor(...), Exposed=Window]

But sometimes (eg: in webvr) it is:
[Exposed=Window, Constructor(...)]

Do we want to be consistent with placing this annotation at the end, or does it not matter?

@bzbarsky

This comment has been minimized.

Show comment
Hide comment
@bzbarsky

bzbarsky Sep 15, 2017

Collaborator

It doesn't really matter; extended attributes form an unordered set.

Collaborator

bzbarsky commented Sep 15, 2017

It doesn't really matter; extended attributes form an unordered set.

anssiko added a commit to w3c/presentation-api that referenced this issue Sep 19, 2017

anssiko added a commit to w3c/battery that referenced this issue Sep 21, 2017

tobie added a commit to tobie/webidl that referenced this issue Nov 15, 2017

Make [Exposed] mandatory, remove [PrimaryGlobal]
Fix [Global] to also take just an identifier
Annotate all interfaces in examples with [Exposed]

Fixes #365.
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26425.

alexshalamov added a commit to alexshalamov/deviceorientation that referenced this issue Nov 22, 2017

Use [Exposed=Window] extended attribute
For more information, please refer to heycam/webidl#365

Fixes: #45

yongsheng pushed a commit to yongsheng/dom that referenced this issue Dec 4, 2017

annevk added a commit to web-platform-tests/wpt that referenced this issue Dec 6, 2017

IDL: remove [PrimaryGlobal]
See heycam/webidl#365 for context.

(The removal of the Window interface altogether in several places was tested and did not affect the results in either Chrome or Firefox.)

annevk added a commit to whatwg/html that referenced this issue Dec 6, 2017

tobie added a commit that referenced this issue Dec 6, 2017

Make [Exposed] mandatory, remove [PrimaryGlobal] (#423)
Fix [Global] to also take just an identifier
Annotate all interfaces in examples with [Exposed]

Fixes #365.
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26425.

jgraham added a commit to web-platform-tests/wpt that referenced this issue Dec 18, 2017

IDL: remove [PrimaryGlobal]
See heycam/webidl#365 for context.

(The removal of the Window interface altogether in several places was tested and did not affect the results in either Chrome or Firefox.)

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Jan 3, 2018

Pramod B S Commit Bot
IDL: Add [Exposed=Window] to MutationObserver and DOMTokenList
Required [Exposed] to get rid of [PrimaryGlobal]

Spec: heycam/webidl#365

Bug: 792432
Change-Id: I4ed66ed7116eaf4ded7d07d991c81c01e827ca1c
Reviewed-on: https://chromium-review.googlesource.com/847393
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526622}

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Jan 4, 2018

Pramod B S Commit Bot
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Required [Exposed] to get rid of [PrimaryGlobal]

Spec: heycam/webidl#365

Bug: 792432
Change-Id: I48abf9f25dc5968da5680d8e95598270199ba812
Reviewed-on: https://chromium-review.googlesource.com/848465
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526994}

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Jan 9, 2018

Pramod B S Commit Bot
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Modified files in CSSOM and CSSOM View module.

Spec: heycam/webidl#365

Bug: 792432
Change-Id: I4d38d30ceef4419dc8b52adf8ea3484e42d69e0d
Reviewed-on: https://chromium-review.googlesource.com/856282
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527947}

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Jan 11, 2018

Pramod B S Commit Bot
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Modified files in DeviceOrietation event,
DOM parsing, serialization and HTML Standard.

Spec: heycam/webidl#365

Bug: 792432
Change-Id: If80340f9a1daa04a4f89fc6adcb08a5dce4dd45f
Reviewed-on: https://chromium-review.googlesource.com/858937
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#528565}

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Jan 17, 2018

Pramod B S Commit Bot
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Modified files in imagecapture, mediarecorder and
presentation modules.

Spec: heycam/webidl#365

Bug: 792432
Change-Id: Ica4e157ab6b962bf185823ef6e6163c34bfb03cb
Reviewed-on: https://chromium-review.googlesource.com/868091
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529594}

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Jan 23, 2018

Pramod B S Commit Bot
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Modified files in core/events module.

Spec: heycam/webidl#365

Bug: 792432
Change-Id: Ie5422d805a6be8fd61292ed2d0ed752020b36724
Reviewed-on: https://chromium-review.googlesource.com/880425
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#531187}

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Feb 2, 2018

Pramod B S Commit Bot
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Modified files in peerconnection module.

Spec: heycam/webidl#365

Bug: 792432
Change-Id: Ic3c8c895d6d71737b07aca504662ab756b06a9d9
Reviewed-on: https://chromium-review.googlesource.com/896916
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534028}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment