HH-128854 add barrier for synchronize up workers and consul registration #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasgribanov
force-pushed
the
HH-128854
branch
2 times, most recently
from
1ede6ac
to
e99bdf2
Compare
dzharikhin
approved these changes
May 5, 2021
| timeout = time.time() + options.init_workers_timeout_sec | ||
| while init_workers_count_down.value > 0: | ||
| if time.time() > timeout: | ||
| raise Exception(f'workers did not started after {options.init_workers_timeout_sec} seconds') |
There was a problem hiding this comment.
тут можно поспать мс 100, вообще говоря
There was a problem hiding this comment.
а зачем? Чтобы процесс не крутился в активном состоянии постоянно?
nicholasgribanov
force-pushed
the
HH-128854
branch
from
206b2f7
to
b9b6cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.