Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scraper for afghankitchenrecipes.com #379

Merged
merged 10 commits into from
May 18, 2021
Merged

Conversation

jayaddison
Copy link
Collaborator

This scraper would benefit from an implementation of #301 - the example recipe includes instructions and ingredients that relate to separate components of the resulting meal.

@gaurav19063
Copy link

@jayaddison How many files have you changed and add for adding new website. could you please provide a summary and is it working fine?

@jayaddison
Copy link
Collaborator Author

Hi @gaurav19063 - usually there are four files that we need to modify for each website:

  • [add] Python scraper code for the website
  • [add] A test HTML file
  • [add] A Python unit test that reads the HTML file and runs the scraper -- this helps to check that the scraper is working correctly
  • [modify] The main recipe-scrapers Python module to add the scraper

Your comment made me realize that I'd accidentally added two HTML files here. Thanks!

@jayaddison
Copy link
Collaborator Author

jayaddison commented May 13, 2021

@gaurav19063 Also, one more detail: there is a utility script called generate.py that can do a lot of the work of adding the new files and updating the main module for us.

@hhursev
Copy link
Owner

hhursev commented May 18, 2021

Adding the site in the README and squash merge / bump version 🤔 lgtm

@jayaddison jayaddison merged commit da4fe71 into master May 18, 2021
@jayaddison jayaddison deleted the afghankitchenrecipes branch May 18, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants