Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lecker.de articles #611

Merged
merged 6 commits into from
Oct 30, 2022
Merged

Fix lecker.de articles #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
374d310
fixes #448 by allowing to import body text of lecker de articles
vabene1111 Sep 30, 2022
2e33b5d
raise exception if calling total time on lecker de articles instead o…
vabene1111 Oct 1, 2022
1b26d6a
added simple test case for lecker de article parser
vabene1111 Oct 1, 2022
9c22718
proper linting of lecker.de parser
vabene1111 Oct 1, 2022
b7a35cf
updated lecker 1 test data and test
vabene1111 Oct 1, 2022
abbe278
lecker 2 test assertEqual instead of assert in
vabene1111 Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions recipe_scrapers/lecker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,16 @@ def author(self):
return self.schema.author()

def title(self):
return self.schema.title()
try:
return self.schema.title()
except TypeError:
return (
self.soup.find(
"header", {"class": "article-header article-header--article"}
)
.find("h1")
.get_text()
)

def category(self):
return self.schema.category()
Expand All @@ -36,7 +45,13 @@ def ingredients(self):
return self.schema.ingredients()

def instructions(self):
return self.schema.instructions()
if self.schema.instructions():
return self.schema.instructions()
else:
divs = self.soup.find_all("div", {"class": "js-quizToggle"})
for d in divs:
if d.find("span", "article__shifted-jump-label"):
return d.get_text()

def ratings(self):
return self.schema.ratings()
Expand Down
Loading