Continuous integration: re-enable coveralls test coverage upload #637
Conversation
|
🤔 It doesn't look like this worked - I expected to see an additional coveralls checkmark in the GitHub Actions results. |
|
Could be that we have to pass the token like in here . I'll take a look tomorrow too. |
| uses: AndreMiras/coveralls-python-action@develop | ||
| with: | ||
| # coveralls repo token | ||
| github-token: "SmlfzlVJy4ow55rduU7IU5GmmFCfAdGeq" |
There was a problem hiding this comment.
I think we should be able to use a GitHub encrypted secret to pass this along, and then this could become something like github-token: ${{ secrets.coveralls_repository_token }}
There was a problem hiding this comment.
Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
which is stopping me from implementing. I'd like to see the coveralls report when builds are triggered by PRs from forked repos
There was a problem hiding this comment.
Sigh, nothing is ever easy with computers :( That's an annoying limitation, makes sense to use the fixed token (I hope it's only valid for use with this repository on the Coveralls side).
I had disabled Coveralls during #628 (a bugfix to make our continuous integration run as we intend on multiple operating systems) because I noticed that it looked like a token value was exposed.
This pull request re-enables coveralls - I'll also check whether it makes sense to enable parallel mode at the same time.