-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19812: Improvements on the Maven Enhance Plugin #11013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eLazyInitialization' default values and deprecate the setting Signed-off-by: Koen Aers <koen.aers@gmail.com>
…Plugins Signed-off-by: Koen Aers <koen.aers@gmail.com>
…he enablement parameters are false Signed-off-by: Koen Aers <koen.aers@gmail.com>
… using Maven Invoker Signed-off-by: Koen Aers <koen.aers@gmail.com>
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
…n in the User's Guide Signed-off-by: Koen Aers <koen.aers@gmail.com>
@yrodiere I have recreated the PR with a better structure (creating JIRA tickets for each aspect) and taking into account your remarks on the former PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a few comments, but only one thing is important: the migration guide change should go to 7.0, not to 7.1 or 7.2.
Regarding #10835 (comment) , I think there was a misunderstanding: I meant that we needed a Jira issue for the backwards-incompatible change, so that it appears in the changelog and doesn't get bundled together with a simple documentation change. I didn't mean you needed a subtask for every single change :)
Anyway, it's good to have details so let's keep the many Jiras, but please don't feel like you have to go that far next time!
… using Maven Invoker - Remove 'testLogging' during the 'integrationTest' execution Signed-off-by: Koen Aers <koen.aers@gmail.com>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19820
https://hibernate.atlassian.net/browse/HHH-19813
https://hibernate.atlassian.net/browse/HHH-19817