Skip to content

Conversation

koentsje
Copy link
Member

@koentsje koentsje commented Sep 26, 2025

  • HHH-19813: Fix the regression on the 'enableDirtyTracking' and 'enableLazyInitialization' default values and deprecate the setting
  • HHH-19817: Add the JavaDoc Style documentation appropriate for Maven Plugins
  • HHH-19820: Make sure that the enhancer is not doing anything if all the enablement parameters are false
  • HHH-19816: Add Integration Tests for the Maven Enhance Plugin without using Maven Invoker
  • HHH-19815: Review and Complete the documentation of the Enhance Plugin in the User's Guide
  • HHH-19814: Document the Enhance Plugin changes in the Migration Guide

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19820
https://hibernate.atlassian.net/browse/HHH-19813
https://hibernate.atlassian.net/browse/HHH-19817

…eLazyInitialization' default values and deprecate the setting

Signed-off-by: Koen Aers <koen.aers@gmail.com>
…Plugins

Signed-off-by: Koen Aers <koen.aers@gmail.com>
…he enablement parameters are false

Signed-off-by: Koen Aers <koen.aers@gmail.com>
… using Maven Invoker

Signed-off-by: Koen Aers <koen.aers@gmail.com>
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Sep 29, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

…n in the User's Guide

Signed-off-by: Koen Aers <koen.aers@gmail.com>
@koentsje
Copy link
Member Author

@yrodiere I have recreated the PR with a better structure (creating JIRA tickets for each aspect) and taking into account your remarks on the former PR.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few comments, but only one thing is important: the migration guide change should go to 7.0, not to 7.1 or 7.2.

Regarding #10835 (comment) , I think there was a misunderstanding: I meant that we needed a Jira issue for the backwards-incompatible change, so that it appears in the changelog and doesn't get bundled together with a simple documentation change. I didn't mean you needed a subtask for every single change :)
Anyway, it's good to have details so let's keep the many Jiras, but please don't feel like you have to go that far next time!

… using Maven Invoker

  - Remove 'testLogging' during the 'integrationTest' execution

Signed-off-by: Koen Aers <koen.aers@gmail.com>
@yrodiere yrodiere merged commit d432a4c into hibernate:main Oct 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants