Skip to content

Conversation

dmlloyd
Copy link
Contributor

@dmlloyd dmlloyd commented May 8, 2018

No description provided.

@dmlloyd dmlloyd changed the title HHH-10435 Create class loaders in a privileged block HHH-10435 Create class loaders in a privileged block (5.1) May 8, 2018
@gbadner
Copy link
Contributor

gbadner commented May 10, 2018

The test mentioned in HHH-10435 does not fail in EAP 7.1, so there is no test to reproduce this issue.

This fix is a first step to fixing HHH-12542, so I'm going to put off merging this PR until HHH-12542/WFLY-9064 is fixed.

@dmlloyd
Copy link
Contributor Author

dmlloyd commented May 10, 2018

https://ci.wildfly.org/viewLog.html?buildId=96925&tab=buildResultsDiv&buildTypeId=WF_MasterSecurityManager#testNameId219335434146728075 does fail; I'm not certain that EAP is doing full test runs with the security manager enabled though. So, I would say there is a test that reproduces the issue.

@dmlloyd
Copy link
Contributor Author

dmlloyd commented May 10, 2018

In any event the problem is statically verifiable (there is an execution path that goes from deployment to class loader creation with no intervening doPrivileged block), so I'd say a reproducing test isn't necessary to show that there is a problem.

@gbadner
Copy link
Contributor

gbadner commented Mar 3, 2021

Closing because 5.1 is no longer maintained. HHH-10435 has been fixed in newer versons.

@gbadner gbadner closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants