HHH-6738 - Hardcoded alias causing problems #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good idea with the constants :) |
lukasz-antoniak
added a commit
that referenced
this pull request
Feb 4, 2012
HHH-6738 - Hardcoded alias causing problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch and test for HHH-6738 JIRA issue.
Link: https://hibernate.onjira.com/browse/HHH-6738
Adam, please review my changes.
Perhaps we could resolve this by adding configuration parameter that allows users to customize audit entity name prefix (instead of hardcoding alias) or even specify alias itself. On the other hand, introducing extra parameters that would be used by only one project team does not make much sense to me and only increases documentation size :). BTW "_h" stands for "historical".
I don't think that anyone's package name would start with "e_h" :).
Regards,
Lukasz Antoniak