HHH-13604 Check APIs used after the SessionFactory has been created

[fax4ever]

https://hibernate.atlassian.net/browse/HHH-13604

I had to comment some code, since regex pattern compile is still used at runtime. not anymore!

At the very moment the rules are active only for CheckForbiddenAPIAtRuntimeTest run.
In order to apply the rules to all tests, please remove or comment:

// TODO HHH-13604 Temporary loading the rules only for CheckForbiddenAPIAtRuntimeTest.
if ( !"CheckForbiddenAPIAtRuntimeTest".equals( clazz.getSimpleName() ) ) {
  return;
}

of org.hibernate.testing.junit4.runtimecheck.BMRuntimeCheckCustomRunner class.

[fax4ever]

It seems that skipping all the cases when the Pattern#regex is called from some class initialization method at any level, the test works.

@Sanne thanks for help you've provided so far,
now I'm going to try to apply the same rules to the whole test phase.At the moment I wouldn't know how to do it, but I can explore the case...

[Sanne]

I'm going to try to apply the same rules to the whole test phase.At the moment I wouldn't know how to do it, but I can explore the case...

yes please! That's what we need.

[fax4ever]

Hi @Sanne, it seems that our investment has borne some fruits.

In fact, activating the Byteman rules we can catch both some readings of annotations and some compations of new regular expressions after that the session factory has been created.

As a follow up, I created: HHH-13669

The rules are not active, in order to keep the tests from failing.
To active those, you can comment some code in BMRuntimeCheckCustomRunner class.

Meanwhile is it the case to merge this request and close the related issue? Thanks

[NathanQingyangXu]

maybe we should check parameter's class before down casting

[NathanQingyangXu]

Given that id field is not generated, it seems the above two methods should be based on it exclusively.

[NathanQingyangXu]

maybe using getter method is more appropriate for two reasons:

• be consistent with equals() method above
• proxy friendly

[NathanQingyangXu]

Not a big deal, but using space chars right after '(' and before ')' would be consistent with existing coding format

[NathanQingyangXu]

You might well use throw new ExceptionInInitializerError( e );

[NathanQingyangXu]

Now I understand your implementation of equals for sake of testing purpose. We might well use Assert.assertTrue(EqualsBuilder.reflectionEquals(expected,actual)); to avoid providing a non-intuitive equals overridden method.

[fax4ever]

I'm closing this pull request, I could reopen it if we need it.