Skip to content

Conversation

pb00067
Copy link

@pb00067 pb00067 commented Apr 26, 2012

Includes patch and testcases for HHH-7278

@pb00067
Copy link
Author

pb00067 commented May 2, 2012

Please ignore the commit 1e6cf8e, it belongs actually to #324, sorry for the confusion, getting crazy with github

@sebersole
Copy link
Member

i can't ignore certain commits in a particular pull request. The problem is that you are using the same branch for each of these "topics". In developing with git, each unique piece of work should go on a separate branch, typically called a topic branch. Its a branch dedicated to that topic/feature/bug/etc.

Pull requests then name that branch. When we go to apply a pull request, we have to apply it based on the branch name. There are lots of reasons for this. Heck, as it is, #324 contains all your recent pull request work.

@sebersole
Copy link
Member

See #324 instead

@sebersole sebersole closed this May 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants