Skip to content

Conversation

ulkitz
Copy link

@ulkitz ulkitz commented Oct 11, 2014

As the middle entity contains only the id columns, any where-clause refering to a column of one of the associated tables leads to an sql-error, as the sql refers to an unknown column.
The lines I removed came in with commit ed2d72e to fix [HHH-4633]. But the test described there executes successfully with and without my change.

As the middle entity contains only the id columns, any where-clause refering to a column of one of the associated tables leads to an sql-error,
as the sql refers to an unknown column.
@sebersole sebersole closed this Oct 29, 2014
@dreab8
Copy link
Member

dreab8 commented Oct 29, 2014

For the details https://hibernate.atlassian.net/browse/HHH-9432

The pull request solution is not to consider the @where attribute clause, I'm not sure if it's better to add the inheritance discriminator column in the to the Auditable generated table.

Considering also the patch breaks BasicWhereJoinTable test

Thanks

@ulkitz
Copy link
Author

ulkitz commented Nov 4, 2014

Hi,

thanks for reviewing the patch. Do you have any code hints where to add the discriminator column?

Thanks in advance,
Ulrich

Date: Wed, 29 Oct 2014 04:01:43 -0700
From: notifications@github.com
To: hibernate-orm@noreply.github.com
CC: ulkitz@hotmail.de
Subject: Re: [hibernate-orm] HHH 9432 Remove where clause from middle entity (#824)

For he details https://hibernate.atlassian.net/browse/HHH-9432

The pull request solution is not to consider the @where attribute clause, I'm not sure if it's better to add the inheritance discriminator column in the to the Auditable generated table.

Considering also the patch breaks BasicWhereJoinTable test

Thanks


Reply to this email directly or view it on GitHub. =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants