Skip to content

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Oct 17, 2024

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18737

@quaff quaff marked this pull request as draft October 17, 2024 08:53
@quaff quaff marked this pull request as ready for review October 17, 2024 08:57
@quaff quaff marked this pull request as draft October 17, 2024 08:59
@quaff quaff marked this pull request as ready for review October 17, 2024 09:28
@quaff
Copy link
Contributor Author

quaff commented Oct 17, 2024

Ready for review @gavinking

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quaff, appreciated.

@gavinking
Copy link
Member

Thanks @quaff, appreciated.

Also appreciate your patience on all this.

@quaff
Copy link
Contributor Author

quaff commented Oct 17, 2024

Thanks @quaff, appreciated.

Also appreciate your patience on all this.

It’s my honor to participate in this great project.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 21, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [41b63af, 68bfe67]

› This message was automatically generated.

@gavinking gavinking merged commit 2f7052c into hibernate:main Nov 22, 2024
19 of 23 checks passed
@gavinking
Copy link
Member

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants