Skip to content

Conversation

maesenka
Copy link
Member

@maesenka maesenka commented Oct 23, 2024

This is a proposal to fix the Failing unit test in BatchUpdateAndVersionTest on CockroachDB.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18760

@maesenka maesenka requested a review from beikov October 23, 2024 19:49
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a minor improvement suggestion

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 24, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@beikov
Copy link
Member

beikov commented Oct 29, 2024

Please squash the commits and rebase, then this can be merged.

@maesenka maesenka merged commit b5fb125 into hibernate:main Oct 29, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants