Skip to content

Conversation

gbadner
Copy link
Contributor

@gbadner gbadner commented May 13, 2015

… use configuration specifed by hibernate.cache.infinispan.cfg

This pull request:

  • adds the new Infinispan 7.2 configuration as a test resource;
  • fixes test cases to use hibernate.cache.infinispan.cfg to determine the Infinispan configuration to use;
  • incorporates some test fixes from galderz@b825be2;
  • corrects org.hibernate.test.cache.infinispan.tm.XaTransactionImpl.commit() to check for synchonizations == null to avoid NullPointerException.

It is currently a manual process to run hibernate-infinispan unit tests with Infinispan 7.2:

  • In libraries.gradle change infinispan version from 6.0.0.Final to 7.2.1.Final;
  • cd hibernate-infinispan
  • ../gradlew clean test -Dhibernate.cache.infinispan.cfg=src/test/resources/infinispan-7-configs.xml

… use configuration specifed by hibernate.cache.infinispan.cfg
gbadner referenced this pull request in galderz/hibernate-orm May 13, 2015
* By doing so, Hibernate 4.3 can read standalone XML configurations
for both Infinispan 6.x and 7.x versions.
* In Infinispan 7, clear is not transactional and hence does not
need a new transaction around it, so protect against that in region
invalidation code.
* Other minor testsuite adjustments that also present in master.
@galderz
Copy link
Member

galderz commented May 13, 2015

Looks good to me :)

@galderz
Copy link
Member

galderz commented May 13, 2015

As @Sanne said, you might want to create a different HHH to more clearly state the objective.

@gbadner
Copy link
Contributor Author

gbadner commented May 13, 2015

I will amend the commit from this pull request to reference a new jira: https://hibernate.atlassian.net/browse/HHH-9796.

@gbadner gbadner closed this May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants