-
-
Notifications
You must be signed in to change notification settings - Fork 101
[4.2] Migrate to release scripts for documentation publishing #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is the right approach.
We already have a task that copies the documentation from one place to another.
It's here:
hibernate-reactive/release/build.gradle
Line 140 in 21a019c
def updateDocumentationTask = tasks.register( 'updateDocumentation' ) { |
I'm not sure exactly what we need to do here, but it seems we could just copy the documentation in the right place during the release. RIght?
Thanks @DavideD for the hint, I have changed the code to use |
If I understand correctly this change shouldn't affect the current build. Can we merge it or there's something else to do? |
right ... you've got a point here 🙂, utill we update the release script, we'd just copy a few extra files somewhere for no reason 🫣 😃 |
and I think this PR should cover it, in terms of changes to Reactive ... things to keep in mind:
at some point later we'd need to remove the "github upload" that Reactive was already doing, but that can be a next step once we are happy with the docs.hibernate.org, and we add the redirects to hibernate.org so that the reactive docs would take the user to docs.hibernate.org.... |
OK, I'm going to merge these. This way we don't have to deal with future rebase and conflicts. Feel free to create a new issue to keep track of what's left to do when the other part of the release scripts is done |
Fix #2519