Skip to content

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Sep 24, 2025

Fix #2519

Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is the right approach.
We already have a task that copies the documentation from one place to another.
It's here:

def updateDocumentationTask = tasks.register( 'updateDocumentation' ) {

I'm not sure exactly what we need to do here, but it seems we could just copy the documentation in the right place during the release. RIght?

@dreab8
Copy link
Member Author

dreab8 commented Sep 25, 2025

Thanks @DavideD for the hint, I have changed the code to use updateDocumentationTask

@DavideD
Copy link
Member

DavideD commented Sep 25, 2025

If I understand correctly this change shouldn't affect the current build. Can we merge it or there's something else to do?
I'm asking because it's a draft

@marko-bekhta
Copy link
Member

right ... you've got a point here 🙂, utill we update the release script, we'd just copy a few extra files somewhere for no reason 🫣 😃
we just wanted to prepare the changes for all projects before merging

@marko-bekhta
Copy link
Member

and I think this PR should cover it, in terms of changes to Reactive ...
For the release scripts, we just need the docs to be in the "expected location", and then those should take care of the rest...

things to keep in mind:

  • make sure that the directories are created at both doc servers before we try to upload
  • update the release script to move doc upload script to be executed for all projects

at some point later we'd need to remove the "github upload" that Reactive was already doing, but that can be a next step once we are happy with the docs.hibernate.org, and we add the redirects to hibernate.org so that the reactive docs would take the user to docs.hibernate.org....

@DavideD DavideD changed the title Migrate to release scripts for documentation publishing [4.2] Migrate to release scripts for documentation publishing Oct 2, 2025
@DavideD DavideD added documentation Words build Something related to the build ci Changes to the Jenkins pipeline or GitHub workflows 4.2 labels Oct 2, 2025
@DavideD DavideD added this to the 4.2.0.Beta1 milestone Oct 2, 2025
@DavideD DavideD marked this pull request as ready for review October 2, 2025 11:31
@DavideD
Copy link
Member

DavideD commented Oct 2, 2025

OK, I'm going to merge these. This way we don't have to deal with future rebase and conflicts. Feel free to create a new issue to keep track of what's left to do when the other part of the release scripts is done

@DavideD DavideD merged commit a7aa040 into hibernate:main Oct 2, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.2 build Something related to the build ci Changes to the Jenkins pipeline or GitHub workflows documentation Words

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to release scripts for documentation publishing

3 participants