HSEARCH-3976 + HSEARCH-3977 Documentation and bugfix for scrolling #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yrodiere
commented
Jul 31, 2020
yrodiere
commented
- HSEARCH-3976: Document scrolling
- HSEARCH-3977: Scroll always targets all indexes
…instead of a page Otherwise it gets confusing since there's another concept called "pagination" which is in some way the exact opposite of scrolling.
…ssertThatHits So that we can statically import it while still statically importing other assertThat methods.
fax4ever
reviewed
Jul 31, 2020
...rc/main/java/org/hibernate/search/integrationtest/backend/tck/search/SearchMultiIndexIT.java
Show resolved
Hide resolved
…nce it can't be null
|
Nice job, +1 to merge from me |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.