Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Aug 26, 2015

@sebersole
Copy link
Member

Some of these are not alias declarations, but alias uses. I'll add specific in-line comments

@sebersole
Copy link
Member

Also, notice that the license here is Apache License, not LGPL. Fix your file headers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This usage is in fact declaring an alias, but its intent is not to be reusable in other parts of the query. The intent for being able to alias dynamic instantiation arguments is to potentially allow these to name JavaBean-style property names for setter injection rather than needing to use ctors strictly.

@dreab8
Copy link
Member Author

dreab8 commented Aug 27, 2015

@sebersole
Fixed the PR based on your comments.
Thanks

@gunnarmorling
Copy link
Member

@sebersole, @dreab8 What about this one? Can it be merged?

@sebersole
Copy link
Member

I do not like the way this is done, specifically in regards to defining it in the grammar and then handling it in the generated listener/visitor. The problem is "other" listener/visitor impls would cause false positive "collisions". I will push some minor changes on top of this PR shortly.

@sebersole
Copy link
Member

Ok, I applied this to master along with my minor change

@sebersole sebersole closed this Oct 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants