HV-2142 Fix issue wit missing root project dir

Signed-off-by: marko-bekhta <marko.prykladna@gmail.com>

Author: marko-bekhta

performance/pom.xml

@@ -25,6 +25,12 @@
         <enforcer.skip>true</enforcer.skip>
         <deploy.skip>true</deploy.skip>
         <maven.javadoc.skip>true</maven.javadoc.skip>
+        <!--
+            The build-helper-maven-plugin is used to add Bean Validation 2.0 source folder to the BV implementations
+            that are 2.0+. Since we are also using this plugin to parse versions in the root pom we want to control
+            when the sources are added with this property:
+        -->
+        <add.bv2.sources.skip>true</add.bv2.sources.skip>
 
         <!--
         Need to specify something, since the plugin cannot handle empty options. Using something which does not have
@@ -81,6 +87,7 @@
                                 <goal>add-source</goal>
                             </goals>
                             <configuration>
+                                <skipAddSource>${add.bv2.sources.skip}</skipAddSource>
                                 <sources>
                                     <source>${project.basedir}/src/main/java-bv2</source>
                                 </sources>
@@ -163,6 +170,7 @@
             <properties>
                 <beanvalidation-impl.name>Hibernate Validator</beanvalidation-impl.name>
                 <beanvalidation-impl.version>${project.version}</beanvalidation-impl.version>
+                <add.bv2.sources.skip>false</add.bv2.sources.skip>
             </properties>
             <dependencies>
                 <dependency>
@@ -183,15 +191,6 @@
                     <artifactId>log4j</artifactId>
                 </dependency>
             </dependencies>
-            <!-- adding sources for BV 2.0 tests -->
-            <build>
-                <plugins>
-                    <plugin>
-                        <groupId>org.codehaus.mojo</groupId>
-                        <artifactId>build-helper-maven-plugin</artifactId>
-                    </plugin>
-                </plugins>
-            </build>
         </profile>
         <profile>
             <id>hv-6.1</id>
@@ -205,6 +204,7 @@
                 <validation-api.version>2.0.1.Final</validation-api.version>
                 <beanvalidation-impl.name>Hibernate Validator</beanvalidation-impl.name>
                 <beanvalidation-impl.version>6.1.2.Final</beanvalidation-impl.version>
+                <add.bv2.sources.skip>false</add.bv2.sources.skip>
             </properties>
             <dependencies>
                 <dependency>
@@ -227,15 +227,6 @@
                     <artifactId>log4j</artifactId>
                 </dependency>
             </dependencies>
-            <!-- adding sources for BV 2.0 tests -->
-            <build>
-                <plugins>
-                    <plugin>
-                        <groupId>org.codehaus.mojo</groupId>
-                        <artifactId>build-helper-maven-plugin</artifactId>
-                    </plugin>
-                </plugins>
-            </build>
         </profile>
         <profile>
             <id>hv-6.0</id>
@@ -249,6 +240,7 @@
                 <validation-api.version>2.0.1.Final</validation-api.version>
                 <beanvalidation-impl.name>Hibernate Validator</beanvalidation-impl.name>
                 <beanvalidation-impl.version>6.0.19.Final</beanvalidation-impl.version>
+                <add.bv2.sources.skip>false</add.bv2.sources.skip>
             </properties>
             <dependencies>
                 <dependency>
@@ -271,15 +263,6 @@
                     <artifactId>log4j</artifactId>
                 </dependency>
             </dependencies>
-            <!-- adding sources for BV 2.0 tests -->
-            <build>
-                <plugins>
-                    <plugin>
-                        <groupId>org.codehaus.mojo</groupId>
-                        <artifactId>build-helper-maven-plugin</artifactId>
-                    </plugin>
-                </plugins>
-            </build>
         </profile>
         <profile>
             <id>hv-5.4</id>

pom.xml

@@ -215,7 +215,7 @@
 
         <version.antrun.plugin>1.8</version.antrun.plugin>
         <version.assembly.plugin>3.4.2</version.assembly.plugin>
-        <version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
+        <version.buildhelper.plugin>3.6.1</version.buildhelper.plugin>
         <version.bundle.plugin>5.1.4</version.bundle.plugin>
         <version.checkstyle.plugin>3.1.1</version.checkstyle.plugin>
         <version.clean.plugin>3.0.0</version.clean.plugin>
@@ -312,6 +312,19 @@
         <maven.compiler.release>${java-version.main.release}</maven.compiler.release>
         <maven.compiler.testRelease>${java-version.test.release}</maven.compiler.testRelease>
 
+        <!--
+           The absolute path to the root project directory.
+           This property is set by the build-helper plugin.
+           We initialize it to some crude, potentially wrong value,
+           because the Sonar Maven plugin uses this property indirectly,
+           but ignores any change made by other plugins.
+           This default value is the best we can do without the help of a Maven plugin.
+
+           Useful resources:
+            - https://www.mojohaus.org/build-helper-maven-plugin/rootlocation-mojo.html
+        -->
+        <rootProject.directory>${user.dir}</rootProject.directory>
+
         <!-- Set empty default values to avoid Maven leaving property references (${...}) when it doesn't find a value -->
         <!-- Argument passed from the command line -->
         <surefire.jvm.args.commandline></surefire.jvm.args.commandline>
@@ -675,6 +688,21 @@
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>flatten-maven-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>build-helper-maven-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>set-root-location-property</id>
+                        <goals>
+                            <goal>rootlocation</goal>
+                        </goals>
+                        <configuration>
+                            <rootLocationProperty>rootProject.directory</rootLocationProperty>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
         <pluginManagement>
             <plugins>