Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoneType object returned on X.eliminate_zeros() #54

Closed
taibabasit opened this issue Jun 19, 2018 · 1 comment · Fixed by #55
Closed

NoneType object returned on X.eliminate_zeros() #54

taibabasit opened this issue Jun 19, 2018 · 1 comment · Fixed by #55

Comments

@taibabasit
Copy link

iced/iced/normalization/__init__.py

Line 79 in 30c5673

X = X.eliminate_zeros()

It should be corrected to X.eliminate_zeros() without the assignment operator as it is an in-place function.
With the assignment operator, it assigns a None type object to X if no zeros were eliminated.
NelleV added a commit to NelleV/iced that referenced this issue Jun 19, 2018
@NelleV
FIX eliminate_zeros is an inplace operation
9f11a25 
closes hiclib#54
@NelleV NelleV mentioned this issue Jun 19, 2018
Merged
@NelleV
Copy link
Contributor

NelleV commented Jun 19, 2018

Thank you so much for spotting this! I've just created a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX eliminate_zeros is an inplace operation NelleV/iced
2 participants
@NelleV @taibabasit