Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporated zeroOrOne into Constellation #76

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Incorporated zeroOrOne into Constellation #76

merged 3 commits into from
Oct 18, 2019

Conversation

xin-cao
Copy link
Contributor

@xin-cao xin-cao commented Sep 30, 2019

Added zeroOrOne support for SBOL generation. Addressed buggy SBOL related to oneOrMore operator. Addressed redundant operators bug. Extended Goldbar simplification rules to SBOL graph.

…ated to oneOrMore operator. Addressed redundant operators bug. Extended Goldbar simplification rules to SBOL graph.
@xin-cao
Copy link
Contributor Author

xin-cao commented Sep 30, 2019

Do not merge until knox-collapse-epsilon branch -> knox branch.

@coveralls
Copy link

coveralls commented Sep 30, 2019

Coverage Status

Coverage decreased (-0.01%) to 74.848% when pulling 47f3ab8 on sbolZeroOrOne into 47b34ac on knox.

@xin-cao xin-cao requested a review from dany-fu October 4, 2019 17:23
@dany-fu
Copy link
Contributor

dany-fu commented Oct 4, 2019

Can you merge the latest knox into this, and also comment out the console logs you added?

@xin-cao xin-cao closed this Oct 11, 2019
@dany-fu dany-fu reopened this Oct 18, 2019
@dany-fu dany-fu merged commit e1c6b94 into knox Oct 18, 2019
@dany-fu dany-fu deleted the sbolZeroOrOne branch October 18, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants