Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw IOE instead of NPE if OpenSSHKeyV1KeyFile reads an empty file #773

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Throw IOE instead of NPE if OpenSSHKeyV1KeyFile reads an empty file #773

merged 1 commit into from
Apr 1, 2022

Commits on Mar 16, 2022

  1. Throw IOE instead of NPE if OpenSSHKeyV1KeyFile reads an empty file 

    There is a contract that FileKeyProvider.readKey throws an IOException if something goes wrong. Throwing an NPE is not expected by API users. Also, it is much more difficult to find out if the NPE is thrown due to a broken key file, or due to an internal bug.
    @vladimirlagunov
    vladimirlagunov committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1980072 View commit details
    Browse the repository at this point in the history