Splits core module in [core, config] #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also removes: * frees-logging Replaces grpc-all by the minimum dependencies with grpc Other.
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 84.29% 83.62% -0.68%
==========================================
Files 12 14 +2
Lines 121 116 -5
==========================================
- Hits 102 97 -5
Misses 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a general build cleaning:
frees-rpccore into two different artifacts:coreandconfig, whereconfigwould be now optional.Mandatory:
libraryDependencies += "io.frees" %% "frees-rpc-core" % "0.6.1"Optional:
libraryDependencies += "io.frees" %% "frees-rpc-config" % "0.6.1"frees-logging.grpc-allby the minimum dependencies with grpc: grpc-core, grpc-stub and grpc-netty.AutoPlugin.Breaking changes:
freestyle.rpc.server.configandfreestyle.rpc.client.config.freestyle-loggingis not provided byfrees-rpcanymore.GrpcServerApp@module has been removed,GrpcServercan be used instead.