Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigDecimal and java.time encoders/decoders implicit instances are now optional #373

Merged
merged 3 commits into from
Jul 27, 2018
Merged

BigDecimal and java.time encoders/decoders implicit instances are now optional #373

merged 3 commits into from
Jul 27, 2018

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Jul 26, 2018 •
edited
Loading

Fixes #370

Moves the BigDecimal and java.time instances related with avro4s and pbdirect serialization to new objects.

  • Services defined in scala files need to add the new imports if they are using the mentioned types.
  • Services defined in avdl doesn't need to do any changes, the same instances are provided in the scope.

@fedefernandez fedefernandez requested a review from a team July 26, 2018 14:52
juanpedromoreno
juanpedromoreno approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fedefernandez fedefernandez changed the title BigDecimal and java.time encoders/decoders implicit instances as optional BigDecimal and java.time encoders/decoders implicit instances are now optional Jul 27, 2018
@fedefernandez fedefernandez merged commit 1e50acf into master Jul 27, 2018
@fedefernandez fedefernandez deleted the ff-implicit-instances-as-optional branch July 27, 2018 10:41
@juanpedromoreno juanpedromoreno mentioned this pull request Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedefernandez @juanpedromoreno