Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix Proto Code Generator for Custom Types #42

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

juanpedromoreno
Copy link
Member

Type.Arg within the input parameters are optional (Option[scala.meta.Type.Arg]). Hence, toString method was printing the file with the existential type. For example:

message CustomType2 {
   string foo = 1;
   Some(CustomType1) bar = 2;
}

This fix comes to solve it, making the output as follows:

message CustomType2 {
   string foo = 1;
   CustomType1 bar = 2;
}

@raulraja raulraja merged commit 3a1dd6c into master Sep 6, 2017
@raulraja raulraja deleted the jp-bug-fix-protogen-custom-types branch September 6, 2017 14:47
@codecov-io
Copy link

codecov-io commented Sep 6, 2017

Codecov Report

Merging #42 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   10.83%   10.75%   -0.08%     
==========================================
  Files          20       20              
  Lines         277      279       +2     
  Branches        1        0       -1     
==========================================
  Hits           30       30              
- Misses        247      249       +2
Impacted Files Coverage Δ
rpc/src/main/scala/proto/converters.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabf7ec...c4b368a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants