Docs update #475
Merged
Docs update #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependent libraries to installation section.
… dependent libraries to installation section.
L-Lavigne
reviewed
Nov 14, 2018
There was a problem hiding this comment.
Thanks for a much-needed cleanup, very thorough!
I like having the macro compiler plugin where readers will see it. Can you add a note to place it after the sbt dependencies section as we've found out?
I'm not sure about the build failure here: https://travis-ci.org/higherkindness/mu/jobs/454747533. This might be one of the intermittent errors we're trying to fix through the streaming rewrite. Can you try re-triggering that build?
|
Thanks @L-Lavigne, I added the note about where the compiler plugin should go in the build.sbt file and that re-triggered the build. It looks like it passed! |
fedefernandez
requested changes
Nov 14, 2018
juanpedromoreno
approved these changes
Nov 14, 2018
fedefernandez
approved these changes
Nov 14, 2018
|
Talked to Fede in person, we can merge this now and include the Fede's suggestion in #472 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… dependent libraries to installation section.
First stab at addressing #474.