Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings sbt-frees-protogen as a separate Artifact #49

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

juanpedromoreno
Copy link
Member

Towards fixing of #25, this PR separates the protocol buffer files generation from the frees-rpc core.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@codecov-io
Copy link

Codecov Report

Merging #49 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   12.01%   11.92%   -0.09%     
==========================================
  Files          20       21       +1     
  Lines         283      285       +2     
  Branches        2        1       -1     
==========================================
  Hits           34       34              
- Misses        249      251       +2
Impacted Files Coverage Δ
protogen/src/main/scala/proto/converters.scala 0% <ø> (ø)
rpc/src/main/scala/proto/annotations.scala 0% <ø> (ø) ⬆️
protogen/src/main/scala/ProtoCodeGen.scala 0% <ø> (ø)
protogen/src/main/scala/proto/encoders.scala 0% <ø> (ø)
protogen/src/main/scala/proto/processors.scala 0% <ø> (ø)
protogen/src/main/scala/ProtoGenPlugin.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e7d44...fbf29de. Read the comment docs.

@juanpedromoreno juanpedromoreno merged commit c375b9f into master Oct 5, 2017
@juanpedromoreno juanpedromoreno deleted the feature/sbt-frees-protogen branch October 5, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants