Channel Interceptor Metrics #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 81.42% 81.63% +0.21%
==========================================
Files 64 65 +1
Lines 985 1002 +17
Branches 17 18 +1
==========================================
+ Hits 802 818 +16
- Misses 183 184 +1
Continue to review full report at Codecov.
|
fedefernandez
force-pushed
the
ff/channel-metrics
branch
from
ae40c07
to
11eae25
Compare
fedefernandez
changed the title
fedefernandez
requested review from
juanpedromoreno,
franciscodr and
jdesiloniz
jdesiloniz
approved these changes
Jan 21, 2019
juanpedromoreno
approved these changes
Jan 21, 2019
modules/channel/src/main/scala/higherkindness/mu/rpc/channel/ManagedChannelConfig.scala
Outdated
Show resolved
Hide resolved
modules/channel/src/main/scala/higherkindness/mu/rpc/channel/ManagedChannelConfig.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: fedefernandez <720923+fedefernandez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review.
It adds the metrics interceptor for the channels.