Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and reorganizes modules #560

Merged
merged 7 commits into from
Mar 13, 2019
Merged

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Feb 5, 2019

Fixes #517

It also finishes the metrics migration

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #560 into master will decrease coverage by 2.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #560      +/-   ##
=========================================
- Coverage   84.87%   82.1%   -2.78%     
=========================================
  Files          71      62       -9     
  Lines        1124     950     -174     
  Branches       16      13       -3     
=========================================
- Hits          954     780     -174     
  Misses        170     170
Impacted Files Coverage Δ
.../mu/rpc/internal/interceptors/GrpcMethodInfo.scala 100% <ø> (ø) ⬆️
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb3c1a...0f4bc5c. Read the comment docs.

@fedefernandez fedefernandez changed the title [WIP] - Update docs and reorganizes modules Update docs and reorganizes modules Mar 12, 2019
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fedefernandez !

LGTM on green :)

@fedefernandez fedefernandez merged commit ca120d9 into master Mar 13, 2019
@fedefernandez fedefernandez deleted the ff/517-metrics-modules branch March 13, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants