Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups async implicits into AsyncInstances trait #71

Merged
merged 3 commits into from
Oct 30, 2017

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Oct 30, 2017

This PR groups the set of async common instances (Future, Task) into the AsyncInstances trait. Then these implicits are provided for both server and client implicit imports:

import freestyle.rpc.server.implicits._ or import freestyle.rpc.client.implicits._.

Fixes #70
Fixes #66

@codecov-io
Copy link

codecov-io commented Oct 30, 2017

Codecov Report

Merging #71 into master will decrease coverage by 0.85%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   89.38%   88.52%   -0.86%     
==========================================
  Files          12       12              
  Lines         113      122       +9     
==========================================
+ Hits          101      108       +7     
- Misses         12       14       +2
Impacted Files Coverage Δ
rpc/src/main/scala/server/implicits.scala 100% <ø> (ø) ⬆️
rpc/src/main/scala/AsyncInstances.scala 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc69a1c...aeeb50f. Read the comment docs.

@eperinan eperinan self-requested a review October 30, 2017 09:25
Copy link
Contributor

@eperinan eperinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and really useful this change !

@juanpedromoreno juanpedromoreno merged commit 01724d9 into master Oct 30, 2017
@juanpedromoreno juanpedromoreno deleted the feature/jp-70-implicits-management branch October 30, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants