Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Avro marshaller #740

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Simplify Avro marshaller #740

merged 1 commit into from
Jan 6, 2020

Conversation

cb372
Copy link
Member

@cb372 cb372 commented Jan 6, 2020

What this does?

Simplify the code for parsing an incoming request as Avro.

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #740 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   81.34%   81.39%   +0.05%     
==========================================
  Files          73       73              
  Lines        1163     1161       -2     
  Branches       15       14       -1     
==========================================
- Hits          946      945       -1     
+ Misses        217      216       -1
Impacted Files Coverage Δ
...higherkindness/mu/rpc/internal/encoders/avro.scala 82.02% <100%> (-0.4%) ⬇️
...kindness/mu/rpc/idlgen/avro/AvroSrcGenerator.scala 76.66% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3312c...6ecc0a7. Read the comment docs.

@cb372 cb372 merged commit ff243a3 into master Jan 6, 2020
@cb372 cb372 deleted the simplify-avro-marshaller branch January 6, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants