Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitter channel badge #743

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix gitter channel badge #743

merged 1 commit into from
Jan 10, 2020

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Jan 10, 2020

What this does?

Fixes the Gitter channel badge. This is a temporary solution until #742 gets in place.

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #743 into master will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #743      +/-   ##
=========================================
+ Coverage   81.05%   81.3%   +0.25%     
=========================================
  Files          73      73              
  Lines        1161    1161              
  Branches       14      14              
=========================================
+ Hits          941     944       +3     
+ Misses        220     217       -3
Impacted Files Coverage Δ
...kindness/mu/rpc/idlgen/avro/AvroSrcGenerator.scala 75% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b2c65...9743fca. Read the comment docs.

@fedefernandez fedefernandez merged commit e036019 into master Jan 10, 2020
@fedefernandez fedefernandez deleted the ff/gitter-badge branch January 10, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants