Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the documentation for sbt-mu-srcgen key changes #765

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Update the documentation for sbt-mu-srcgen key changes #765

merged 1 commit into from
Jan 28, 2020

Conversation

naree
Copy link
Contributor

@naree naree commented Jan 27, 2020 •
edited
Loading

What this does?

This is the documentation update for #764

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

@codecov
Copy link

codecov bot commented Jan 27, 2020 •
edited
Loading

Codecov Report

Merging #765 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #765   +/-   ##
=======================================
  Coverage   71.23%   71.23%           
=======================================
  Files          68       68           
  Lines        1036     1036           
  Branches       13       13           
=======================================
  Hits          738      738           
  Misses        298      298

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f6d55...ea69dc9. Read the comment docs.

cb372
cb372 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@cb372 cb372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is a draft PR? LGTM.

@naree
Copy link
Contributor Author

naree commented Jan 28, 2020 •
edited
Loading

@cb372 thanks for reviewing it. Basically my paranoia 😆 I thought I would review it one more time to see if I missed any.

@naree naree marked this pull request as ready for review January 28, 2020 10:36
juanpedromoreno
juanpedromoreno approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@naree naree merged commit a46d35d into master Jan 28, 2020
@naree naree deleted the document-mu-srcgen-plugin-key-changes branch January 28, 2020 11:26
@naree naree mentioned this pull request Jan 28, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@cb372 cb372 cb372 approved these changes

@fedefernandez fedefernandez Awaiting requested review from fedefernandez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naree @cb372 @juanpedromoreno