Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annotations #908

Merged
merged 1 commit into from
May 4, 2020
Merged

Remove annotations #908

merged 1 commit into from
May 4, 2020

Conversation

cb372
Copy link
Member

@cb372 cb372 commented May 4, 2020

The @option, @outputPackage and @outputName annotations were left over from the old IDL generation feature.

To avoid sbt-mu-srcgen generating code containing @option annotations, there is a dependency on:

  1. Don't add @option when generating Mu code skeuomorph#275 being merged
  2. new version of skeuomorph being released
  3. sbt-mu-srcgen's skeuomorph dependency being upgraded

What this does?

Changes, features, fixes ...

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

The `@option`, `@outputPackage` and `@outputName` annotations were left
over from the old IDL generation feature.
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #908 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   88.55%   88.58%   +0.02%     
==========================================
  Files          58       58              
  Lines         830      832       +2     
  Branches        3        3              
==========================================
+ Hits          735      737       +2     
  Misses         95       95              
Impacted Files Coverage Δ
.../src/main/scala/higherkindness/mu/rpc/config.scala 100.00% <0.00%> (ø)
.../main/scala/higherkindness/mu/http/implicits.scala 81.25% <0.00%> (ø)
.../scala/higherkindness/mu/rpc/testing/servers.scala 93.75% <0.00%> (ø)
...cala/higherkindness/mu/rpc/server/GrpcServer.scala 84.00% <0.00%> (ø)
...higherkindness/mu/rpc/internal/MonixAdapters.scala 87.50% <0.00%> (ø)
...higherkindness/mu/rpc/internal/encoders/avro.scala 81.60% <0.00%> (ø)
...herkindness/mu/rpc/kafka/KafkaManagementImpl.scala 100.00% <0.00%> (ø)
...kindness/mu/rpc/kafka/kafkaManagementService.scala 55.29% <0.00%> (ø)
...rkindness/mu/rpc/internal/metrics/MetricsOps.scala 97.05% <0.00%> (ø)
...u/rpc/internal/service/GRPCServiceDefBuilder.scala 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45163a0...7222f20. Read the comment docs.

@cb372 cb372 merged commit d413a9b into master May 4, 2020
@cb372 cb372 deleted the remove-annotations branch May 4, 2020 13:43
@cb372 cb372 mentioned this pull request May 4, 2020
2 tasks
@cb372 cb372 added the breaking-change A breaking change that needs to be treated with consideration label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants