Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces Boilerplate in Server creation #98

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Dec 18, 2017

Before:

val grpcConfigs: List[GrpcConfig] = List(
    AddService(
      YourService.bindService[YourConcurrentMonad]
    )
  )

  implicit def grpcServerHandler: GrpcServer.Op ~> YourConcurrentMonad =
    new GrpcServerHandler[YourConcurrentMonad] andThen
      new GrpcKInterpreter[YourConcurrentMonad](ServerW(port, grpcConfigs).server)

After this PR:

Before:

val grpcConfigs: List[GrpcConfig] = List(
    AddService(
      YourService.bindService[YourConcurrentMonad]
    )
  )
implicit val serverW: ServerW = ServerW(port, grpcConfigs)

Additionally, this PR:

  • Unifies test utilities to DRY between @tagless and @service tests.
  • Removes ETA Expansion warnings.
  • Removes bootstrapFuture syntax.
  • Removes all those imports that are not used anymore.
  • Others.

* Unifies test utilities to DRY among @tagless and @service tests
* Removes ETA Expansion warnings
* Removes bootstrapFuture syntax
* Removes all those imports that are not used anymore
* Others
@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

Merging #98 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   83.21%   83.45%   +0.24%     
==========================================
  Files          12       12              
  Lines         137      139       +2     
==========================================
+ Hits          114      116       +2     
  Misses         23       23
Impacted Files Coverage Δ
rpc/src/main/scala/internal/MonixAdapters.scala 80% <ø> (ø) ⬆️
rpc/src/main/scala/server/implicits.scala 100% <100%> (ø) ⬆️
.../src/main/scala/client/handlers/TaskMHandler.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4597dfc...52fe03a. Read the comment docs.

@juanpedromoreno juanpedromoreno merged commit 4c2e012 into master Dec 18, 2017
@juanpedromoreno juanpedromoreno deleted the jp-reduces-boilerplate-for-server branch December 18, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants