Adds the parameters to an operation #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! This looks like a needed addition, thanks Fede! I think that, in the case of the parameter ADT, you want the occurrences of Json Schema types to be typed as A, not JsonSchemaF[A]. Sorry, I’m on my phone, but I’ll try to catch-up with this later on |
Modify operation encoder to use Encoder.instance(some recursion problem)
for JsonSchemaF
Reference should be part of JsonSchemaF.
Remove name from object in JsonSchemaF. Extract jsonType method to generate Json.
Review the not required elements in the open api model.
Create a companion object in test to improve readability.
Refactor test helper function.
Fix operation encoder.
Verify codecRoundTrip law for Open Api Codecs. Create an encoder for Fix. Add circe-testing dependency.
Remove unused comments/code.
BeniVF
requested review from
pepegar,
juanpedromoreno,
diesalbla,
vil1 and
peterneyens
juanpedromoreno
approved these changes
May 10, 2019
pepegar
requested changes
May 10, 2019
There was a problem hiding this comment.
This is awesome @BeniVF, thank you very much for all your work here.
I have asked for some minor changes in the decoder part, in order to not specify the interface for decoders to Fix[JsonSchemaF], and allow any Embed[JsonSchemaF, A] to be used.
Apart of that, it looks very nice!
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
Remove unnecessary use of apply.
diesalbla
reviewed
May 13, 2019
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
diesalbla
approved these changes
May 14, 2019
There was a problem hiding this comment.
Code looks nice, at least for a first iteration.
I have a couple of suggestions, which can be addressed in follow-up PRs:
- In the relevant decoders, or schema definitions, add references (links) to the Open API specification.
- As a way of testing, validate if our schema parser can handle the examples in https://github.com/OAI/OpenAPI-Specification/tree/master/examples.
src/main/scala/higherkindness/skeuomorph/openapi/JsonDecoders.scala
Outdated
Show resolved
Hide resolved
- requestBody in Operation is optional in Open api. - format in string is open for users to define their own types. - object in case you define properties the spec allows to avoid the field type Use explicit method for Decoder[Option[Map[String, A]]] Required is optional for Parameter.
BeniVF
approved these changes
May 15, 2019
This was referenced Jul 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.