Upgrades skeuomorph Build #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
force-pushed
the
jp-upgrades-build
branch
from
1fd2642
to
b186fa8
Compare
juanpedromoreno
force-pushed
the
jp-upgrades-build
branch
from
b186fa8
to
1c292fb
Compare
juanpedromoreno
force-pushed
the
jp-upgrades-build
branch
from
3ad0edb
to
b1dfc56
Compare
juanpedromoreno
requested review from
pepegar,
fedefernandez and
franciscodr
juanpedromoreno
commented
Sep 23, 2019
| def mapStringToGen[A](gen: Gen[A]): Gen[Map[String, A]] = Gen.mapOfN(2, Gen.zip(nonEmptyString.map(_.take(4)), gen)) | ||
| // TODO: after Scalacheck 1.14.1 upgrade this generator doesn't work anymore | ||
| //def mapStringToGen[A](gen: Gen[A]): Gen[Map[String, A]] = Gen.mapOfN(2, Gen.zip(nonEmptyString.map(_.take(4)), gen)) | ||
| def mapStringToGen[A](gen: Gen[A]): Gen[Map[String, A]] = gen.map(a => Map(UUID.randomUUID.toString.take(4) -> a)) |
There was a problem hiding this comment.
This would need to be fixed in a separate PR: #142
2 tasks
pepegar
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #141
This PR upgrades skeuomorph to cats and cats-effect 2.0.0, along with the rest of dependencies except droste (maybe it can be tackled in a different PR).
After upgrading to the latest cats ecosystem version two test files need to be fixed since now the laws are broken:
higherkindness.skeuomorph.openapi.OpenApiSchemaSpechigherkindness.skeuomorph.PrinterSpecAdditionally, this PR removes the Scala 2.11 compatibility (
circe0.12.x doesn't support it anymore).Update: OpenApiSchemaSpec was failing because of the new version of Scalacheck (1.14.1) and how generators are currently built.