Error with Rollup CommonJS plugin

[frangio]

I'm trying to use this dependency in an application bundled with Rollup, and this line is causing trouble for the CommonJS plugin:

highlightjs-solidity/solidity.js

Line 11 in a23372f

var module = module ? module : {}; // shim for browser use

When I remove this everything works correctly. I think this line causes the plugin to not be able to detect the module exports.

@haltman-at Any idea why this line is here?

[haltman-at]

No idea! I didn't write that...

[joshgoebel]

This solidity grammar is doing a very complex export. We recommend simply exporting default now, ie:

export default function(hljs) {
  return {
    name: 'Plain text',
    aliases: [
      'text',
      'txt'
    ],
    disableAutodetect: true
  };
}

(or the equivalent in CJS land) The grammar shouldn't concern itself with how it's loaded/registered in a browser, that's what the CDN distributable our build system creates (if your grammar is in the extra folder) solves. It only needs to export the grammar function itself.

[joshgoebel]

Actual example: https://github.com/highlightjs/highlightjs-robots-txt/blob/master/src/robots-txt.js

[joshgoebel]

Related: highlightjs/highlight.js#3008

[haltman-at]

OK, sorry this took so long, but we've finally published a 2.0 version that fixes this!