-
Notifications
You must be signed in to change notification settings - Fork 17
Syntax update for Solidity 0.8.5: Add verbatim
builtin in assembly
#48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@frangio @joshgoebel @marcoscaceres @pospi Hey, does anyone know who has permission to add people to this repo? @frangio has said he no longer has time to help out with this, so I need someone else who can check my work, including the Solidity-specific parts. However I don't seem to have permission to add people to this repo so I can ask them for reviews. |
I can. Who would you like added. |
Well, I asked other people here at Truffle, and @cds-amal and @eggplantzzz have both said they'd be willing to do this. :) |
Added with Write permissions. |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add tests for these changes?
Well, the current way we have tests set up is not great, so testing is a bit difficult (we don't have tests for most things...) but I could add a quick test that |
OK, I added a quick test, if it helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY @haltman-at ! It does help, and now this looks good to me!
This PR adds highlighting for the
verbatim
family of assembly builtins introduced in 0.8.5. Rather than handling these by the crazy way I handled fixed-point types (I should probably redo those at some point...) I just used a regular expression. So this means it gets its own mode rather than just being a keyword.Also, while I was at it, I added a second commit to require that numbers are followed by a word break, since we didn't have that previously.