Restrict highlighting of verbatim to standalone Yul #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Looks good @haltman-at .
What do you think of adding an issue referencing adding verbatim to solidity assembly for visibility?
|
Not sure what you mean... I linked to that issue? Is there something additional I should do there? Edit: Oh, I see, you want me to add a new issue here about that. Yeah, not going to bother since it's not an issue yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
verbatimcurrently only exists in standalone Yul, not in Solidity assembly. So, I restricted it to standalone Yul. We can revert this commit later ifverbatimis eventually brought to Solidity assembly, which I believe is planned.Also I upped the timeout on the test of
verbatim, because it was timing out when I ran it locally (probably due to being in a meeting at the time :P ).