Support unmarshalling custom classes

[langsamu]

Thanks for a great library.

It would be a nice feature to be able to unmarshal to custom JavaScript classes.
I've implemented this in two ways:

1. Rewrite Jsonix.Model.ClassInfo so unmarshal creates an instance of a custom class (instead of an empty object) to be used as the result if a type is defined in typeInfo.
   (7329373 and working example)
2. Derive Jsonix.Model.CustomClassInfo from ClassInfo so unmarshal creates an instance of a custom class and extends it with attributes from super class' result.
   (0b79975 and working example)

What do you think?

[highsource]

Hi,

thanks for the feedback and the nice feature proposal.

I'd opt to the first approach you propose. However I'd rename typeInfo into
something like constructorFunction or instanceFactory. Few other thinks to
consider is the "isInstance" method and tests
I'll work over it and release with 2.0.11.

Best wishes,
Alexey

On Thu, Aug 21, 2014 at 6:38 PM, Samu Lang notifications@github.com wrote:

Thanks for a great library.

It be a nice feature to be able to unmarshal to custom JavaScript classes.
I've implemented this in two ways:

Rewrite Jsonix.Model.ClassInfo so unmarshal creates an instance of a
custom class (instead of an empty object) to be used as the result if a
type is defined in typeInfo.
(7329373
7329373
and working example http://jsfiddle.net/langsamu/Lg4zjz9g/)
2.

Derive Jsonix.Model.CustomClassInfo from ClassInfo so unmarshal
creates an instance of a custom class and extends it with attributes from
super class' result.
(0b79975
0b79975
and working example http://jsfiddle.net/langsamu/7aeqbme0/)

What do you think?

—
Reply to this email directly or view it on GitHub
#20.

[langsamu]

Updated working example to use instanceFactory and isInstance.

[highsource]

This should be done now - with instanceFactory as we've discussed.
Please see this test: https://github.com/highsource/jsonix/tree/master/nodejs/tests/basic/tests/Two
(customClassValue-0.xml).
Will be released with 2.0.11, hopefully coming today.

deserializing directly to custom objects (without .name or .value extras) is great. Is this feature in a release?

[highsource]

Yes and no.
Yes, issue #20 is in the current release.
No, the functionality you're referring to is on element infos. This feature is only for class infos.
However this might work for element infos exactly the same way. Please file an issue.