Skip to content

Add option to specify lambda via image_uri #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 21, 2022
Merged

Conversation

nmnielsen
Copy link
Contributor

@nmnielsen nmnielsen commented Sep 21, 2022

Are there any dependencies (software or human) that need to be addressed before this PR is merged?

What ticket(s) or other PRs does this relate to?

What was the problem or feature?

Want to be able to create a Lambda based on an image in ECR.

What was the solution?

Add the image_uri option to the variables and to the creation of the Lambda resource. Additionally add verifications and conditionals to ensure that we don't specify conflicting S3 and ECR configurations. (this commit, we can add these once we get to Terraform > 1.2.0)

  • Security Impact has been considered (if yes please describe): none
  • Network Impacts have been considered (if yes please describe): none

Where does this work fall on the Good - Fast spectrum?

Any additional work needed as a result of merging this PR (deploy steps, other PRs, etc.)?

@nmnielsen nmnielsen marked this pull request as ready for review September 21, 2022 17:55
@nmnielsen
Copy link
Contributor Author

Alright! That took more iterations than I expected - should be ready to review now!

@nmnielsen nmnielsen merged commit 760a490 into master Sep 21, 2022
@nmnielsen nmnielsen deleted the image-uri-option branch September 21, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants