Skip to content

set package_type parameter #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022
Merged

set package_type parameter #18

merged 1 commit into from
Sep 22, 2022

Conversation

nmnielsen
Copy link
Contributor

Are there any dependencies (software or human) that need to be addressed before this PR is merged?

What ticket(s) or other PRs does this relate to?

What was the problem or feature?

Sneaky optional package_type parameter defaults to "Zip", even if you specify an image_uri

What was the solution?

Specify package_type

  • Security Impact has been considered (if yes please describe): none
  • Network Impacts have been considered (if yes please describe): none

Where does this work fall on the Good - Fast spectrum?

Any additional work needed as a result of merging this PR (deploy steps, other PRs, etc.)?

@nmnielsen nmnielsen marked this pull request as ready for review September 22, 2022 17:01
@nmnielsen nmnielsen merged commit 19663a5 into master Sep 22, 2022
@nmnielsen nmnielsen deleted the package-type branch September 22, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants