added timeouts to avoid memory leaking #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frvade
approved these changes
Nov 27, 2023
|
@estahn could you please help with the review and merge here maybe 🙏 The related issue is very actual because it leads to repeating OOM killer alerts |
…maximum request execution time
|
i rebased this to allow for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the fcgi client does not get a response, without the timeout, it will never free the waitgroup in the Update function and never free the mutex in the Collect function. This stops the metrics endpoint from responding. Requests will get queued until the process gets killed with out of memory.
To prevent this, first a timeout was added for the fcgi client and second a timeout and limit was added for the incoming requests.
This issue was also reported in #253.