Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PoxConfig improvements #616

Merged
merged 7 commits into from
Jul 18, 2024
Merged

feat: PoxConfig improvements #616

merged 7 commits into from
Jul 18, 2024

Conversation

tippenein
Copy link
Contributor

@tippenein tippenein commented Jul 10, 2024 •
edited
Loading

closes #547

  • remove redundant PoxConfig and update uses to the chainhooks::types version
  • allow PoxConfig settings as parameters

@tippenein tippenein temporarily deployed to Development-mainnet July 10, 2024 01:18 — with GitHub Actions Inactive
@tippenein tippenein temporarily deployed to Development-testnet July 10, 2024 01:18 — with GitHub Actions Inactive
@hugocaillard
Copy link
Contributor

CI is broken @tippenein

@tippenein tippenein mentioned this pull request Jul 12, 2024
Open
@tippenein tippenein temporarily deployed to Development-mainnet July 16, 2024 19:29 — with GitHub Actions Inactive
@tippenein tippenein temporarily deployed to Development-testnet July 16, 2024 19:29 — with GitHub Actions Inactive
@hugocaillard hugocaillard self-requested a review July 18, 2024 14:21
hugocaillard
hugocaillard approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tippenein

@tippenein tippenein merged commit 2924ebc into main Jul 18, 2024
13 of 15 checks passed
@tippenein tippenein deleted the pox-config-refactor branch July 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocaillard hugocaillard hugocaillard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept PoxConfig as a parameter and normalize the type
2 participants
@tippenein @hugocaillard